2:58 p.m.
VETO
Start with xemacs -vanilla, C-h f rassoc RET, bye-bye XEmacs!
Repeatable. Revert the patch, no crash.
By the way, there are changes in src/symbols.c and src/sysfile.h that
aren't in the ChangeLog. I assume these are due to your commit.
>>>> "Aidan" == Aidan Kehoe
<kehoea(a)parhasard.net> writes:
Aidan> Doesn’t work for ELL modules yet, but I’m not waiting for
Aidan> that to commit, because I have a feeling if I ever get to
Aidan> it, it’ll be a long time in the future, and the code is
Aidan> plenty useful as it is.
Here's the trace:
(gdb) bt
#0 0xffff8a60 in __memcpy ()
#1 0x000d2e64 in coding_reader (stream=0x37ade90, data=0xbfffcdb0
"Return non-nil if VALUE is `equal' to the cdr of an element of
ALIST.\nThe value is actually the element of ALIST whose cdr equals
VALUE.\n\narguments: (VALUE
ALIST)\n\037Sfns.c\n\037Fold-rassoc\nReturn non-nil i"...,
size=1090519040) at
/Users/steve/Software-Development/XEmacs/git-staging/src/file-coding.c:1805
#2 0x00188f40 in Lstream_raw_read (lstr=0x37ade90, buffer=0xbfffcdb0
"Return non-nil if VALUE is `equal' to the cdr of an element of
ALIST.\nThe value is actually the element of ALIST whose cdr equals
VALUE.\n\narguments: (VALUE
ALIST)\n\037Sfns.c\n\037Fold-rassoc\nReturn non-nil i"...,
size=1090519040) at
/Users/steve/Software-Development/XEmacs/git-staging/src/lstream.c:628
#3 0x0018924c in Lstream_read_1 (lstr=0x37ade90, data=0xbfffcdb0,
size=1090519040, override_no_partial_chars=0) at
/Users/steve/Software-Development/XEmacs/git-staging/src/lstream.c:688
#4 0x001894b0 in Lstream_read (lstr=0x37ade90, data=0xbfffcdb0,
size=1090519040) at
/Users/steve/Software-Development/XEmacs/git-staging/src/lstream.c:743
#5 0x00058028 in extract_object_file_name (fd=1919819886,
doc_pos=1869491566, name_nonreloc=0x696c2069 <Address 0x696c2069 out
of bounds>, name_reloc={...}, standard_doc_file=1280656672) at
/Users/steve/Software-Development/XEmacs/git-staging/src/doc.c:88
#6 0x2e630a1f in ?? ()
================================================================
System Info to help track down your bug:
---------------------------------------
uname -a: Darwin papa 7.9.0 Darwin Kernel Version 7.9.0: Wed Mar 30 20:11:17 PST 2005;
root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC Power Macintosh powerpc
../configure '--with-mule' '--with-widgets=athena'
'--with-dialogs=athena' '--with-athena=3d' '--with-number-lib=gmp'
'--with-debug' '--with-error-checking=all'
'--with-xft=emacs,tabs,gauges,menubars' '--with-site-prefixes=/opt/local'
'--with-union-type' '--with-xim=no'
XEmacs 21.5-b26 "endive" (+CVS-20060421) configured for
`powerpc-apple-darwin7.9.0'.
Compilation Environment and Installation Defaults:
Source code location: /Users/steve/Software-Development/XEmacs/git-staging
Installation prefix: /usr/local
Additional prefixes: /opt/local
Operating system description file: `s/darwin.h'
Machine description file: `m/powerpc.h'
Compiler version: gcc (GCC) 3.3 20030304 (Apple Computer, Inc. build
1666)
- GCC specs file: /usr/libexec/gcc/darwin/ppc/3.3/specs
- Compiler command: gcc -Wall -Wno-switch -Wundef -Wsign-compare
-Wno-char-subscripts -Wpacked -Wpointer-arith -Wunused-parameter -g
libc version:
Relocating allocator for buffers: no
GNU version of malloc: no
- The GNU allocators don't work with this system configuration.
Window System:
Compiling in support for the X window system:
- X Windows headers location: /usr/X11R6/include
- X Windows libraries location: /usr/X11R6/lib
- Handling WM_COMMAND properly.
- Using fontconfig to manage fonts.
- Compiling in support for Xft antialiased fonts (EXPERIMENTAL).
Compiling in support for the Athena widget set:
- Athena headers location: X11/Xaw3d
- Athena library to link: Xaw3d
Using Lucid menubars.
- Using Xft to render antialiased fonts in menubars.
WARNING: This feature will be replaced with a face.
Using Lucid scrollbars.
Using Athena dialog boxes.
Using Athena native widgets.
- Using Xft to render antialiased fonts in tab controls.
WARNING: This feature will be replaced with a face.
- Using Xft to render antialiased fonts in progress bars.
WARNING: This feature will be replaced with a face.
WARNING: This feature not yet implemented; setting ignored.
TTY:
Compiling in support for ncurses.
Images:
Compiling in support for GIF images (builtin).
Compiling in support for XPM images.
Compiling in support for PNG images.
Compiling in support for JPEG images.
Compiling in support for TIFF images.
Sound:
Databases:
Compiling in support for Berkeley database.
Compiling in support for GNU DBM.
Compiling in support for LDAP.
Compiling in support for PostgreSQL.
- Using PostgreSQL header file: libpq-fe.h
Internationalization:
Compiling in support for Mule (multi-lingual Emacs).
Compiling in support for Canna on Mule.
Mail:
Compiling in support for "file" mail spool file locking method.
Other Features:
Inhibiting IPv6 canonicalization at startup.
Compiling in support for dynamic shared object modules.
Using the union type for Lisp_Objects.
WARNING: ---------------------------------------------------------
WARNING: This tends to trigger compiler bugs, especially when
WARNING: combined with MULE and ERROR_CHECKING. Crashes have
WARNING: been seen with various versions of GCC (up to about 2.95),
WARNING: and recently with Visual C++ as well (mid-2003).
WARNING: More recent versions may be safer, or not.
WARNING: ---------------------------------------------------------
Using the new GC mark algorithms (KKCC).
WARNING: ---------------------------------------------------------
WARNING: The new algorithms are experimental. They are enabled by
WARNING: default for this release. Use `--disable-kkcc' to
WARNING: turn it off.
WARNING: ---------------------------------------------------------
Using the new portable dumper.
Dumping into executable.
Compiling in support for extra debugging code.
Compiling in support for runtime error checking.
WARNING: ---------------------------------------------------------
WARNING: XEmacs will run noticeably more slowly as a result.
WARNING: Error checking is on by default for XEmacs beta releases.
WARNING: ---------------------------------------------------------
Load-Path Lisp Shadows:
----------------------
(/usr/local/lib/xemacs/mule-packages/lisp/mule-base/viet-util
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/mule/viet-util
/usr/local/lib/xemacs/mule-packages/lisp/mule-base/korea-util
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/mule/korea-util
/usr/local/lib/xemacs/mule-packages/lisp/mule-base/japan-util
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/mule/japan-util
/usr/local/lib/xemacs/mule-packages/lisp/mule-base/ethio-util
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/mule/ethio-util
/usr/local/lib/xemacs/mule-packages/lisp/mule-base/cyril-util
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/mule/cyril-util
/usr/local/lib/xemacs/mule-packages/lisp/mule-base/china-util
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/mule/china-util
/usr/local/lib/xemacs/mule-packages/lisp/mule-ucs/unicode
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/unicode
/usr/local/lib/xemacs/xemacs-packages/lisp/xemacs-base/regexp-opt
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/regexp-opt
/usr/local/lib/xemacs/xemacs-packages/lisp/xemacs-base/easy-mmode
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/easy-mmode
/usr/local/lib/xemacs/xemacs-packages/lisp/build/build-report
/Users/steve/Software-Development/XEmacs/git-staging/+build/lisp/build-report)
Installed XEmacs Packages:
-------------------------
(zenirc ver: 1.16 upstream: 2.112)
(xwem ver: 1.21 upstream: lg(a)xwem.org--2005/xwem--main--2.1--versionfix-1)
(xslt-process ver: 1.12 upstream: 1.2.1)
(xslide ver: 1.09 upstream: 0.2.2)
(xlib ver: 1.14 upstream: lg(a)xwem.org--2005/xlib--main--2.1--version-0)
(xetla ver: 1.0 upstream: steve(a)eicq.org--2005/xetla--main--1.0--version-0)
(xemacs-devel ver: 1.71 upstream: No-Upstream-Ver)
(xemacs-base ver: 1.98 upstream: No-Upstream-Ver)
(x-symbol ver: 1.1 upstream: 4.5.1)
(w3 ver: 1.31 upstream: 4.0pre47)
(vm ver: 7.22 upstream: 7.17)
(viper ver: 1.42 upstream: 3.09)
(view-process ver: 1.13 upstream: 2.4)
(vhdl ver: 1.2 upstream: 3.33.2)
(vc-cc ver: 1.22 upstream: No-Upstream-Ver)
(tramp ver: 1.26 upstream: 2.0.50)
(tpu ver: 1.14 upstream: 4.2X)
(tooltalk ver: 1.15 upstream: No-Upstream-Ver)
(tm ver: 1.38 upstream: No-Upstream-Ver)
(time ver: 1.14 upstream: 1.17)
(textools ver: 1.15 upstream: No-Upstream-Ver)
(text-modes ver: 1.88 upstream: No-Upstream-Ver)
(texinfo ver: 1.29 upstream: No-Upstream-Ver)
(supercite ver: 1.2 upstream: 3.55x3)
(strokes ver: 1.1 upstream: No-Upstream-Ver)
(speedbar ver: 1.28 upstream: 0.14beta4)
(sounds-wav ver: 1.12 upstream: No-Upstream-Ver)
(sounds-au ver: 1.12 upstream: No-Upstream-Ver)
(sml-mode ver: 0.12 upstream: 3.9.5)
(slider ver: 1.15 upstream: 0.3x1)
(sieve ver: 1.17 upstream: No-Upstream-Ver)
(sh-script ver: 1.18 upstream: 2.0e)
(sgml ver: 1.11 upstream: No-Upstream-Ver)
(semantic ver: 1.19 upstream: 1.4.2)
(scheme ver: 1.14 upstream: No-Upstream-Ver)
(sasl ver: 1.15 upstream: 1.14.4)
(ruby-modes ver: 1.02 upstream: 1.6.8)
(rmail ver: 1.14 upstream: No-Upstream-Ver)
(riece ver: 1.2 upstream: 2.0.0)
(reftex ver: 1.34 upstream: 4.21)
(re-builder ver: 1.05 upstream: 1.20)
(python-modes ver: 1.06 upstream: No-Upstream-Ver)
(psgml-dtds ver: 1.03 upstream: No-Upstream-Ver)
(psgml ver: 1.44 upstream: 1.3.1)
(ps-print ver: 1.11 upstream: 6.5.6)
(prog-modes ver: 2.05 upstream: No-Upstream-Ver)
(pgg ver: 1.05 upstream: 0.1)
(perl-modes ver: 1.08 upstream: No-Upstream-Ver)
(pcomplete ver: 1.04 upstream: 1.1.6)
(pcl-cvs ver: 1.66 upstream: R-2_9_9)
(pc ver: 1.28 upstream: No-Upstream-Ver)
(os-utils ver: 1.36 upstream: No-Upstream-Ver)
(oo-browser ver: 1.04 upstream: 4.08)
(ocaml ver: 0.05 upstream: 3.06)
(net-utils ver: 1.46 upstream: N/A)
(mmm-mode ver: 1.02 upstream: 0.4.7)
(misc-games ver: 1.18 upstream: No-Upstream-Ver)
(mine ver: 1.16 upstream: 1.9)
(mh-e ver: 1.29 upstream: 7.4.2)
(mew ver: 1.19 upstream: 1.94.2)
(mailcrypt ver: 2.14 upstream: 3.5.8)
(mail-lib ver: 1.73 upstream: No-Upstream-Ver)
(liece ver: 1.14 upstream: 1.4.9)
(jde ver: 1.48 upstream: 2.3.2)
(ispell ver: 1.31 upstream: 3.6)
(ilisp ver: 1.33 upstream: 5.12.0)
(igrep ver: 1.13 upstream: 2.111)
(idlwave ver: 1.32 upstream: 5.1)
(ibuffer ver: 1.09 upstream: No-Upstream-Ver)
(hyperbole ver: 1.16 upstream: 4.18)
(hm--html-menus ver: 1.23 upstream: 5.9)
(haskell-mode ver: 1.07 upstream: 1.45)
(gnus ver: 1.85 upstream: 5.10.7)
(gnats ver: 1.17 upstream: 3.101)
(general-docs ver: 1.04 upstream: No-Upstream-Ver)
(games ver: 1.15 upstream: 1.04)
(fsf-compat ver: 1.15 upstream: No-Upstream-Ver)
(frame-icon ver: 1.11 upstream: No-Upstream-Ver)
(fortran-modes ver: 1.04 upstream: No-Upstream-Ver)
(forms ver: 1.15 upstream: 2.37)
(footnote ver: 1.16 upstream: 0.18x)
(eudc ver: 1.39 upstream: 1.32)
(eterm ver: 1.17 upstream: No-Upstream-Ver)
(ess ver: 1.16 upstream: 5.2.7)
(eshell ver: 1.1 upstream: 2.4.1)
(escreen ver: 1.01 upstream: 1.16)
(erc ver: 0.17 upstream: Version 5.0 Revision: 1.757)
(emerge ver: 1.11 upstream: No-Upstream-Ver)
(elib ver: 1.11 upstream: 1.0)
(eieio ver: 1.05 upstream: 0.17)
(efs ver: 1.33 upstream: 1.23)
(edt ver: 1.13 upstream: No-Upstream-Ver)
(edit-utils ver: 2.25 upstream: No-Upstream-Ver)
(ediff ver: 1.54 upstream: 2.75)
(edebug ver: 1.21 upstream: No-Upstream-Ver)
(ecrypto ver: 0.19 upstream: 2.0)
(ecb ver: 1.22 upstream: 2.31)
(docbookide ver: 0.07000000000000001 upstream: 0.1)
(dired ver: 1.17 upstream: 7.13)
(dictionary ver: 1.16 upstream: 1.8)
(debug ver: 1.17 upstream: No-Upstream-Ver)
(crisp ver: 1.15 upstream: 1.34)
(cookie ver: 1.15 upstream: No-Upstream-Ver)
(clearcase ver: 1.1 upstream: /main/laptop/165)
(cc-mode ver: 1.45 upstream: 5.30.10)
(calendar ver: 1.23 upstream: No-Upstream-Ver)
(calc ver: 1.26 upstream: 2.02fX3)
(c-support ver: 1.22 upstream: No-Upstream-Ver)
(build ver: 1.14 upstream: 2.02)
(bbdb ver: 1.28 upstream: 2.34)
(auctex ver: 1.46 upstream: 11.55)
(apel ver: 1.29 upstream: 10.2)
(ada ver: 1.14 upstream: 2.27)
(Sun ver: 1.16 upstream: No-Upstream-Ver)
(skk ver: 1.23 upstream: 10.62a)
(mule-ucs ver: 1.14 upstream: 0.84)
(mule-base ver: 1.47 upstream: No-Upstream-Ver)
(lookup ver: 1.15 upstream: 1.0)
(locale ver: 1.22 upstream: No-Upstream-Ver)
(leim ver: 1.22 upstream: No-Upstream-Ver)
(latin-unity ver: 1.15 upstream: 1.15)
(latin-euro-standards ver: 1.07 upstream: 1.07)
(egg-its ver: 1.27 upstream: No-Upstream-Ver)
(edict ver: 1.16 upstream: 0.9.9)
Installed Modules:
-----------------
Features:
--------
(mail-abbrevs xemacsbug shadow sendmail rfc822 zenirc-autoloads
xwem-autoloads xslt-process-autoloads xslide-autoloads xlib-autoloads
xetla-autoloads xemacs-devel-autoloads xemacs-base-autoloads
x-symbol-autoloads w3-autoloads vm-autoloads viper-autoloads
view-process-autoloads vhdl-autoloads vc-cc-autoloads vc-autoloads
tramp-autoloads tpu-autoloads tooltalk-autoloads tm-autoloads
time-autoloads textools-autoloads text-modes-autoloads
texinfo-autoloads supercite-autoloads strokes-autoloads
speedbar-autoloads sounds-wav-autoloads sounds-au-autoloads
sml-mode-autoloads slider-autoloads sieve-autoloads
sh-script-autoloads sgml-autoloads semantic-autoloads scheme-autoloads
sasl-autoloads ruby-modes-autoloads rmail-autoloads riece-autoloads
reftex-autoloads re-builder-autoloads python-modes-autoloads
psgml-dtds-autoloads psgml-autoloads ps-print-autoloads
prog-modes-autoloads pgg-autoloads perl-modes-autoloads
pcomplete-autoloads pcl-cvs-autoloads pc-autoloads os-utils-autoloads
oo-browser-autoloads ocaml-autoloads net-utils-autoloads
mmm-mode-autoloads misc-games-autoloads mine-autoloads mh-e-autoloads
mew-autoloads mailcrypt-autoloads mail-lib-autoloads liece-autoloads
jde-autoloads ispell-autoloads ilisp-autoloads igrep-autoloads
idlwave-autoloads ibuffer-autoloads hyperbole-autoloads
hm--html-menus-autoloads haskell-mode-autoloads gnus-autoloads
gnats-autoloads general-docs-autoloads games-autoloads
fsf-compat-autoloads frame-icon-autoloads fortran-modes-autoloads
forms-autoloads footnote-autoloads eudc-autoloads eterm-autoloads
ess-autoloads eshell-autoloads escreen-autoloads erc-autoloads
emerge-autoloads elib-autoloads eieio-autoloads efs-autoloads
edt-autoloads edit-utils-autoloads ediff-autoloads edebug-autoloads
ecrypto-autoloads ecb-autoloads docbookide-autoloads dired-autoloads
dictionary-autoloads debug-autoloads crisp-autoloads cookie-autoloads
clearcase-autoloads cc-mode-autoloads calendar-autoloads
calc-autoloads c-support-autoloads build-autoloads bbdb-autoloads
auctex-autoloads apel-autoloads ada-autoloads Sun-autoloads
skk-autoloads mule-ucs-autoloads mule-base-autoloads lookup-autoloads
locale-autoloads leim-autoloads latin-unity-autoloads
latin-euro-standards-autoloads egg-its-autoloads edict-autoloads
mule-autoloads auto-autoloads rsz-minibuf auto-show fontl-hooks
canna-leim tibetan lao devanagari indian slovenian czech romanian ccl
code-cmds gutter-items menubar-items x-menubar mode-motion mouse
behavior itimer auto-save lisp-mode easymenu easy-mmode iso8859-1 page
buff-menu lib-complete loadhist cus-file derived newcomment env
text-props fontconfig frame obsolete cus-start custom widget cl-extra
cl cl-19 packages backquote unicode font-mgr lucid-scrollbars
cut-buffer xft-fonts lucid-menubars athena-dialogs x c-balloon-help
tty-frames tty toolbar scrollbar unix-processes multicast
network-streams subprocesses modules menu-accelerator-support menubar
berkeley-db dbm md5 xemacs mule gutter tiff png gif jpeg xpm xbm
lisp-float-type file-coding darwin dialog devices window-system
base64)
Recent keystrokes:
-----------------
button1 button1up ESC x r e p o r t - x e m a c s -
b u g RET
Recent messages (most recent first):
-----------------------------------
Warning:
Defaulting to the GNU Emacs-derived `sendmail.el' mail client. This facility,
while part of base XEmacs, is heinously underfeatured, and not going to get
better in the medium term. We include it so that bug reports work without
packages; we suggest that you choose and/or install one of the other mail
clients from packages if you're doing something other than M-x
report-xemacs-bug , or even if you are reporting bugs regularly.
To choose a package from those installed, click on "Options" ->
"Internet" -> "Compose Mail With ..." and decide on one from the
list. Gnus and VM are full-featured and have active user communities.
To disable this warning and stick with the old behavior, you can explicitly
initialize `mail-user-agent' to 'sendmail-user-agent .
Loading xemacsbug...done
Loading xemacsbug...
Info: Undefined Unicode key mappings.
Your keyboard has, among many others, the following keysyms defined:
U203A UFB02 U25CA UFB01 UF8FF U2039 U2044 U02C6 U0003 U02DC U2206
The standards say that applications should interpret these keysyms as
representing the corresponding Unicode code points (e.g. U2720 should
represent MALTESE CROSS), but unfortunately the current version of XEmacs
has no support for many of those characters in its internal encoding, and
when it encounters the keysyms corresponding to those characters, they
remain unbound.
See the documentation for `unicode-to-char' for one technique if you have an
urgent need for support for one of those characters--you probably don't,
most of the widely-used characters have mappings in the internal XEmacs
encoding--otherwise, wait until we ship a version with an internal encoding
based on Unicode.
Loading field...done
Loading field...
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
3:53 p.m.
Ar an triochadú lá de mí Aibréan, scríobh Stephen J. Turnbull:
VETO
Start with xemacs -vanilla, C-h f rassoc RET, bye-bye XEmacs!
Repeatable.
Not for me it isn’t. Have you regenerated your DOC file? Though, for me,
using an old doc file just signals an error, it doesn’t crash the process.
Revert the patch, no crash.
On the subject of the veto--if I revert the patch in CVS now, it’s never
going in, because I can’t fix that crash with the information I have.
By the way, there are changes in src/symbols.c and src/sysfile.h
that
aren't in the ChangeLog. I assume these are due to your commit.
They are; I had thought I had committed them already, because they weren’t
appearing in cvs diff for some reason.
--
In the beginning God created the heavens and the earth. And God was a
bug-eyed, hexagonal smurf with a head of electrified hair; and God said:
“Si, mi chiamano Mimi...”
6:30 a.m.
>>>> "Aidan" == Aidan Kehoe
<kehoea(a)parhasard.net> writes:
Aidan> On the subject of the veto--if I revert the patch in CVS
Aidan> now, it’s never going in, because I can’t fix that crash
Aidan> with the information I have.
XEmacs must not crash if we can help it, no matter how evil the data.
If you think you have a fix within a day or so, that's one thing (even
if a day or so turns into a week or a month...). But if you say you
can't fix it, it must come out, no?
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
7:55 a.m.
Ar an chéad lá de mí Bealtaine, scríobh Stephen J. Turnbull:
Aidan> On the subject of the veto--if I revert the patch in
CVS now,
Aidan> it’s never going in, because I can’t fix that crash with the
Aidan> information I have.
XEmacs must not crash if we can help it, no matter how evil the data.
Well, the data here is data we create. It’s not even evil.
If you think you have a fix within a day or so, that's one thing
(even
if a day or so turns into a week or a month...). But if you say you
can't fix it, it must come out, no?
It’s a platform-specific crash that happens on a platform I don’t have
access to. It’s probably not anything wildly complicated. Please, take a
minute, put a breakpoint on extract_object_file_name, tell me space_left has
a sane value and so does p and buffer.
--
Aidan Kehoe, http://www.parhasard.net/
4:44 p.m.
New subject: [21.5] Support builtin functions in find-function (crash in C-h f)
>>>> "Aidan" == Aidan Kehoe
<kehoea(a)parhasard.net> writes:
Aidan> It’s a platform-specific crash that happens on a platform I
Aidan> don’t have access to.
It's not platform-specific, it's just an obvious buffer overrun.
Adding 1 to the dimension of buf fixes the crash for me. Please
review and make sure that's everything.
diff --git a/src/ChangeLog b/src/ChangeLog
index cdf3be7..536e1df 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
＠＠ -0,0 +1,4 ＠＠
+2006-05-02 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * doc.c (extract_object_file_name): Fix buffer overrun.
+
diff --git a/src/doc.c b/src/doc.c
index 0066c5b..fa111a5 100644
--- a/src/doc.c
+++ b/src/doc.c
＠＠ -47,7 +47,7 ＠＠ extract_object_file_name (int fd, EMACS_
Ibyte *name_nonreloc, Lisp_Object name_reloc,
int standard_doc_file)
{
- Ibyte buf[DOC_MAX_FILENAME_LENGTH];
+ Ibyte buf[DOC_MAX_FILENAME_LENGTH+1];
Ibyte *buffer = buf;
int buffer_size = sizeof (buf), space_left;
Ibyte *from, *to;
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
9:53 a.m.
Ar an triochadú lá de mí Aibréan, scríobh Aidan Kehoe:
> By the way, there are changes in src/symbols.c and
src/sysfile.h that
> aren't in the ChangeLog. I assume these are due to your commit.
They are; I had thought I had committed them already, because they weren’t
appearing in cvs diff for some reason.
I’ve added documentation of those changes to the ChangeLog.
--
Aidan Kehoe, http://www.parhasard.net/
6775
days inactive
6781
days old
5 comments
2 participants
participants (2)
-
Aidan Kehoe -
Stephen J. Turnbull