APPROVE COMMIT 21.5 The attached patch just fixes a test that misuses this macro. RFC: I think Aidan's expectation that w-s-a-b-c will initialize point to (point-min) is very natural. Should we make it so? Or should we just document the correct usage of the macro? If so, is somebody willing to grep the core and package sources for uses and check to see if there are any conflicting uses? Also compare to GNU, if they have it! Note: the test as written will remain correct if we make this change. diff -r e96f3aca4d63 -r 5e8f6469169f tests/ChangeLog --- a/tests/ChangeLog Sat Sep 27 16:31:32 2008 +0900 +++ b/tests/ChangeLog Sat Sep 27 16:34:40 2008 +0900 ＠＠ -1,3 +1,8 ＠＠ +2008-09-27 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * automated/regexp-tests.el: `with-string-as-buffer-contents' + leaves point at end of buffer, so must move point to beginning. + 2008-08-27 Aidan Kehoe <kehoea(a)parhasard.net&gt; * automated/regexp-tests.el: diff -r e96f3aca4d63 -r 5e8f6469169f tests/automated/regexp-tests.el --- a/tests/automated/regexp-tests.el Sat Sep 27 16:31:32 2008 +0900 +++ b/tests/automated/regexp-tests.el Sat Sep 27 16:34:40 2008 +0900 ＠＠ -526,6 +526,7 ＠＠ (with-string-as-buffer-contents "-]-----------------------------][]]------------------------" + (goto-char (point-min)) (skip-chars-forward (skip-chars-quote "-[]")) (Assert (= (point) (point-max))) (skip-chars-backward (skip-chars-quote "-[]")) _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta