On Thu, 04 Jul 2002 13:08:12 +0200, Simon Josefsson <jas(a)extundo.com&gt; said: Famous last words. I see clueless people installing pre-releases all the time. Heck, happens to me personally... Hmm.. maybe I need to re-phrase that.. ;)

SJ> I think the last version (1.46) should go into the sumo, to be SJ> on the safe side. SY> Putting a new version in Pre-Release, and then the old version SY> in the Sumo will be tricky, but I'll see what I can do. SY> Just for the record, our packages repository is supposed to be SY> a stable tree, please try to do your best to keep it that way. This patch looks downright dubious to me. It introduces a large number of typos in comments, and a lot of really stupid capitalization in the ISO 3166 list (I dunno, maybe those are the official names...). purecopy'ing a defcustom value seems weird (although recent XEmacsen don't have an effective purecopy anyway, because of pdump-related changes). I don't have time to do a thorough review, but these little things make me quite a bit nervous.... -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN My nostalgia for Icon makes me forget about any of the bad things. I don't have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py

Simon> I only found one, fixed. I'll go back and look again then. Simon> I did not understand why purecopy was used, but it seemed Simon> to work. Should it be removed? Maybe -- there was a purecopy-removing session a while back, I don't remember details. Simon> Most important is probably to try and run it and see if it Simon> breaks. It works for me, and fixes reported bugs So far so good ... Simon> so it can't be all that bad. *snort* Take out the "that" and you're right. ;-) I'll try to do something about using it myself, but I just installed Oort and things are weird .... -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN My nostalgia for Icon makes me forget about any of the bad things. I don't have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py

|--==> "SJ" == Simon Josefsson <jas(a)extundo.com&gt; writes: SJ> "Stephen J. Turnbull" <stephen(a)xemacs.org&gt; writes: SJ> I did not understand why purecopy was used, but it seemed to work. SJ> Should it be removed? The way I understand it, purecopy was only to be used for things that get dumped with xemacs. ,----[ (Info-goto-node "(lispref)Pure Storage") ] | Pure Storage | ============ | | XEmacs Lisp uses two kinds of storage for user-created Lisp objects: | "normal storage" and "pure storage". Normal storage is where all the | new data created during an XEmacs session is kept; see the following | section for information on normal storage. Pure storage is used for | certain data in the preloaded standard Lisp files--data that should | never change during actual use of XEmacs. | | Pure storage is allocated only while `temacs' is loading the | standard preloaded Lisp libraries. In the file `xemacs', it is marked | as read-only (on operating systems that permit this), so that the | memory space can be shared by all the XEmacs jobs running on the machine | at once. Pure storage is not expandable; a fixed amount is allocated | when XEmacs is compiled, and if that is not sufficient for the preloaded | libraries, `temacs' aborts with an error message. If that happens, you | must increase the compilation parameter `PURESIZE' using the | `--puresize' option to `configure'. This normally won't happen unless | you try to preload additional libraries or add features to the standard | ones. | | - Function: purecopy object | This function makes a copy of OBJECT in pure storage and returns | it. It copies strings by simply making a new string with the same | characters in pure storage. It recursively copies the contents of | vectors and cons cells. It does not make copies of other objects | such as symbols, but just returns them unchanged. It signals an | error if asked to copy markers. | | This function is a no-op except while XEmacs is being built and | dumped; it is usually called only in the file | `xemacs/lisp/prim/loaddefs.el', but a few packages call it just in | case you decide to preload them. `---- Looking at that, I'd say yes you should remove _all_ the 'purecopy's from mail-extr.el, but _especially_ from the defcustoms. -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|