On 3/1/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
Hi Vin,
the Lisp part of the patch looks fine---I can do my work on top of
that.
Now, I see there's quite a bit of logic around the setting of
PACKAGE_PATH. This really needs to go. PACKAGE_PATH itself is
deprecated, and the settings in nt/xemacs.mak are just plain wrong for
some configurations. Similarly for PACKAGE_PREFIX. If anything like
PACKAGE_PREFIX needs to be set, it should be the value of
PATH_LATE_PACKAGE_DIRECTORIES.
Hi Michael,
Is the following a minimalist version of what you mean? (This patch
should be applied on top of my earlier patches.)
--- xemacs.mak.~2~ 2006-02-27 22:33:08.142511900 -0500
+++ xemacs.mak 2006-03-09 09:27:18.031578800 -0500
@@ -812,7 +812,7 @@
-DXEMACS_EXTRA_NAME=\"$(xemacs_extra_name:"=)\" \
!endif
!if defined(PATH_PACKAGEPATH)
- -DPATH_PACKAGEPATH=\"$(PATH_PACKAGEPATH)\" \
+ -DPATH_LATE_PACKAGE_DIRECTORIES=\"$(PATH_PACKAGEPATH)\" \
!endif
-DEMACS_CONFIGURATION=\"$(EMACS_CONFIGURATION)\"
TEMACS_CPP_FLAGS=$(CFLAGS) $(TEMACS_CPP_FLAGS_NO_CFLAGS)
@@ -1077,7 +1077,7 @@
!endif
!if defined(PATH_PACKAGEPATH)
# PATH_PACKAGEPATH is already a quoted string.
-! if [echo PACKAGE_PATH>>$(CONFIG_VALUES) && echo
$(PATH_PACKAGEPATH)>>$(CONFIG_VALUES)]
+! if [echo PATH_LATE_PACKAGE_DIRECTORIES>>$(CONFIG_VALUES) && echo
$(PATH_PACKAGEPATH)>>$(CONFIG_VALUES)]
! endif
!endif
I don't understand under what configurations "the settings in
nt/xemacs.mak are just plain wrong".
If my proposal is on the wrong track or doesn't go far enough, please
send me a sample patch. I'm happy to do the scut work of making sure
all the i's are dotted and the t's are crossed and working the bare
bones of your changes into a patch that's ready for prime time.
Thanks,
Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver