Hello Stefan, hello pcl-cvs(a)cyclic.com!
Hey there. pcl-cvs(a)cyclic.com doesn't exist any more.
XEmacs will avoid "version skew" (as Micheal Sperber calls)
it) if at
all possible.
To determine that possibility, I would appreciate a short note from
your end.
Emacs does not have the `menubar' property, so your patch won't work
on Emacs. But furthermore, this is not the only menu used by PCL-CVS,
so I'm wondering why only this one needs to be protected by such a check.
Additionally, I'm wondering if all modes with menus (i.e. all modes)
need (in XEmacs) to check for the `menubar' property before setting up
a menu. I suspect that this is not the case (because I'd trust the XEmacs
team not to make such a mistake), in which case, we should
determine why such a check is required here.
Stefan
Best regards,
Adrian
APA> pcl-cvs-version
APA> "v2_9_9"
APA> Andreas (Jaeger), I would like to commit this to xemacs-packages
APA> shortly, unless there are objections.
APA> Best regards,
APA> Adrian
APA> ChangeLog:
APA> 2000-07-29 Adrian Aichner <aichner(a)ecf.teradyne.com>
APA> * pcl-cvs-defs.el: Guard autoload form using `easy-menu-add-item'
APA> with (featurep 'menubar) for pcl-cvs to work in "xemacs -nw".
APA> Patch:
APA> cd d:\tmp\xemacs-packages\prog\pcl-cvs\
APA> diff -u d:\tmp\xemacs-packages\prog\pcl-cvs\pcl-cvs-defs.el
c:\XEmacs\xemacs-packages\lisp\pcl-cvs\pcl-cvs-defs.el
APA> Compilation started at Sat Jul 29 19:52:52 2000 +0200 (W. Europe Daylight
Time)
APA> --- d:\tmp\xemacs-packages\prog\pcl-cvs\pcl-cvs-defs.el Fri Apr 21 11:58:18
2000
APA> +++ c:\XEmacs\xemacs-packages\lisp\pcl-cvs\pcl-cvs-defs.el Sat Jul 29
19:47:19 2000
APA> @@ -464,13 +464,13 @@
APA> ;;;###autoload
APA> (if (progn (condition-case () (require 'easymenu) (error nil))
APA> - (fboundp 'easy-menu-add-item))
APA> + (and (fboundp 'easy-menu-add-item) (featurep 'menubar)))
APA> (easy-menu-add-item nil '("tools")
APA> - '("PCL CVS"
APA> - ["Update Directory" cvs-update t]
APA> - ["Examine Directory" cvs-examine t]
APA> - ["Status Directory" cvs-status t]
APA> - ["Checkout Module" cvs-checkout t]) "vc"))
APA> + '("PCL CVS"
APA> + ["Update Directory" cvs-update t]
APA> + ["Examine Directory" cvs-examine t]
APA> + ["Status Directory" cvs-status t]
APA> + ["Checkout Module" cvs-checkout t])
"vc"))
APA> ;; cvs-1.10 and above can take file arguments in other directories
APA> Compilation exited abnormally with code 1 at Sat Jul 29 19:52:53
APA> --
APA> Adrian Aichner <adrian(a)xemacs.org>