Re: [S] [PATCH] erc: take 2 to make erc-generate-log-file-name-long and erc-log-file-coding-system xemacs-compatible

Stephen> +(defcustom erc-log-file-coding-system (if (featurep 'xemacs) Stephen> + 'binary Stephen> + 'emacs-mule) Stephen> This will cause data loss if you have non-ISO8859-1 Stephen> characters in the buffer. APA> Any better suggestion, assuming we make 'file-coding a APA> require-ment? I really need to know what the application is, and what kind of coding systems users are actually going to use. At the very least, you are going to need to do (defcustom erc-log-file-coding-system (cond ((not (featurep 'xemacs)) 'emacs-mule) ((featurep 'mule) 'iso-2022-7) ((featurep 'file-coding) 'binary) (t (error "This Emacs doesn't support coding-systems)))) Don't take that `(error ...)' too seriously, you really need to check for the case that coding systems are unsupported where `erc-log-file-coding-system' is used, not at the point of definition. Also, while 'iso-2022-7 is fairly safe (after all, it's just a modal version of emacs-mule), there may be better alternatives. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.