Re: [PATCH] big-menubar.el doesn't work
On Thu, 25 Apr 2002, hniksic(a)arsdigita.com wrote:
Mike Fabian <mfabian(a)suse.de> writes:
> --- packages/xemacs-packages/edit-utils/big-menubar.el Thu Oct 25 12:46:20 2001
> +++ packages/xemacs-packages/edit-utils/big-menubar.el Wed Jan 14 07:36:15 1998
> ＠＠ -29,7 +29,7 ＠＠
> ;;; Code:
>
> (let* ((current-menubar (default-value 'current-menubar))
> - (edit-menu (assoc "Edit" current-menubar)))
> + (edit-menu (assoc "%_Edit" current-menubar)))
This patch looks wrong -- the user code shouldn't have to care about
where the accelerators are. In this case, the correct patch would be
to replace `assoc' with `find-menu-item'. Specifically:
(assoc "Edit" current-menubar)
to
(car (find-menu-item current-menubar '("Edit")))
and:
(assoc "Tools" current-menubar)
to:
(car (find-menu-item current-menubar '("Tools")))
The advantage is that it works not only regardless of where the
accelerators are, but also regardless of the flavor of accelerator
syntax.
The same probably goes for all uses of `assoc' in big-menubar and
elsewhere.
big-menubar.el adds lots of various commands to the menus.
Many of these commands are already in the menus - I think in the 21.4
branch. For example, the macro, sort, register, submenus are in the
cmds window. The file appears to be more or less obsolete.
-jeff