Re: XEmacs and 1x1 gif images
*sigh* I really should relearn to use IRC. Replies keep crossing in
the mail.
Robert Pluim writes:
diff --git a/image-mode.el b/image-mode.el
index e9dd55a..a6959dd 100644
--- a/image-mode.el
+++ b/image-mode.el
＠＠ -82,11 +82,11 ＠＠
(let ((image (and type
(make-image-instance
(vector type :data (buffer-string start end))
- nil nil 'no-error))))
+ nil nil 't))))
<barf/> You're right, this matches the design, but something called
"image-mode" should be prepared for this and do something useful with
the error, rather than silence it and return nil.
(unless image
(setq image (make-image-instance
(vector 'string :data "format is not supported!\n")
This should be "image conversion failed!", because it can easily
happen for supported formats, as you know.
- nil nil 'no-error)))
+ nil nil 't)))
No, here it should be "... nil nil nil)))". If an image instance of
type 'string isn't support, XEmacs is in *big* trouble. (Maybe an
XEmacs that doesn't support any consoles at all? :-)
It does mask a bug though, I think.
Heh. I know that author .... :-P
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta