Re: Failure building packages (Vin Shelton)

Hi, Steven and Byrel - With my modified 21.4, I can now build the packages. Good! However, there are still a few issues with buffer-colors and icon-themes: 1. I cannot load XEmacs 21.4: xemacs -vanilla Loading icon-themes... Loading cus-face... Loading cus-face...done Loading icon-themes...done Symbol's function definition is void: behavior-enabled-p behavior-enabled-p is not defined in 21.4. I probably could import the definition from 21.5, but usually the packages try to work around such incompatibilities. Can you work around the lack of behavior-enabled-p in 21.4? 2. Those messages should not appear on stderr. In fact, IMO, it's bad form for packages to do things like insinuate themselves into the menu system just on loading. The usual way is to create an initialization function that the user must explicitly call in order to invoke the functionality. Here's the hack I threw together to address this: diff -r 6cab68dcb147 buffer-colors.el --- a/buffer-colors.el Sat Jan 07 06:17:23 2012 -0500 +++ b/buffer-colors.el Sun Jan 08 22:36:05 2012 -0500 ＠＠ -407,15 +407,17 ＠＠ ;;;;--- start up code ---------------------------------------------- -;;;###autoload -(unless (featurep 'buffer-colors) +(defun initialize-buffer-colors () + "Load buffer-colors and add an item to the Options menu." + + (unless (featurep 'buffer-colors) + (add-menu-button '("Options" "Display") + "---")) ;add a separator only first time loaded + (add-menu-button '("Options" "Display") - "---")) ;add a separator only first time loaded -;;;###autoload -(add-menu-button '("Options" "Display") - [ "Buffer Colors" bc-toggle-behavior - :style toggle - :selected (behavior-enabled-p 'buffer-colors)]) + [ "Buffer Colors" bc-toggle-behavior + :style toggle + :selected (behavior-enabled-p 'buffer-colors)])) (provide 'buffer-colors) diff -r 6cab68dcb147 icon-themes.el --- a/icon-themes.el Sat Jan 07 06:17:23 2012 -0500 +++ b/icon-themes.el Sun Jan 08 22:36:05 2012 -0500 ＠＠ -349,8 +349,10 ＠＠ ;;;;--- initialize icon-themes ------------------------------------------ -;;;###autoload -(theme-load-menu '("Options") "Display") +(defun initialize-icon-themes () + "Load icon-theme support and add an item to the Options menu." + (theme-load-menu '("Options") "Display") +) ;;;;---- customize group and variables for icon-themes ------------------------------ ＠＠ -445,4 +447,4 ＠＠ (provide 'icon-themes) -;; icon-themes.el ends here \ No newline at end of file +;; icon-themes.el ends here Please let me know if you want me to apply that patch or if you want to do something less hackish. Regards, Vin _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta