Jonathan Marten writes:
On Wednesday 26 November 2008 02:54:07 Stephen J. Turnbull wrote:
> Looks good, as far as it goes.
>
> I'm sorry to come back with this at this point, but since Francois
> Revel has expressed interest in desktop management for BeOS, I wonder
> if `on-desktop' and `current-desktop' (note, no "x-"!)
shouldn't be
> implemented via frame and console methods. You should be able to call
> them on anything that can be resolved to the appropriate object (eg,
> frames and windows, but not buffers).
If you mean what I think you mean (access to this information
should be independent of window system), then that's already done
as part of the patch. The preferred way is via frame properties,
and I assume that the XEmacs console/device system takes care of
calling the appropriate window system-specific functions:
Yes and no. Access to information, yes, but also the internal
interface should be window-system-independent until it dispatches at
the lowest level. I don't much like exposing these x-do-window-op,
ms-do-window-op, ... functions (cf my opinion on `turn-on-foo-mode',
`turn-off-foo-mode'); I would prefer a single do-window-op function
that dispatches to the underlying code. Thus "console methods".
current-desktop is really a property of a console or device (not a
frame), but there is no analogous access to "console properties".
I'm not sure it's worth implementing console properties in general,
but it's certainly possible to add a current_desktop method to struct
console_methods. This would then be automagically dispatched to by
(current-desktop console).
Similarly, I think on-desktop could (and probably should) be
implemented as a frame or console method. The advantage of
implementing as a console method is that you could pass a generic
window ID in console-dependent fashion, such as UINT_32_BIT (IIRC) for
X11.
Comments, Evgeny, François? They don't have to be fully formed, but
you guys probably have thought more about related issues than any of
the current Reviewers.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta