Re: libxml2 support
On Sat, Mar 2, 2013 at 10:49 PM, Jerry James <james(a)xemacs.org> wrote:
On Tue, Feb 5, 2013 at 8:46 AM, Robert Pluim <rpluim(a)gmail.com>
wrote:
> Hi,
>
> I had to make the attached changes to get it to compile for me on cygwin.
I understand the second hunk, but that first hunk can't possibly be
right. The first argument to get_buffer_range_char is a "struct
buffer *", which current_buffer is. Fcurrent_buffer, on the other
hand, is a lisp function. Or was that supposed to be
Fcurrent_buffer()? That still isn't right, as it returns a Lisp
object that wraps a "struct buffer *".
I suspect the problem is the same one as for the second hunk:
current_buffer is not exposed to modules. Try adding current_buffer
to src/xemacs.def.in.in instead. I'll add that to the next iteration
of this patch.
Your analysis seems correct, you've certainly spent more time on it than I
did:). I'll give it a test tomorrow.
> I gave it a quick test with shr in gnus, which caused a
spectacular
crash,
> but the loading & running of libxml2 seems fine.
Might the crash have been due to the problem with the first hunk of the
patch?
Yes. Fcurrent_buffer is in the backtrace, which had me scratching my head.
Robert
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta