Submitting patches
I sent the following to xemacs-patches at the beginning of the month,
got receipts, but have yet to see them on the mailing list.
Were they rejected?
Am I simply being impatient?
- Phil
From: Philip Aston <philipa(a)parallax.co.uk>
To: xemacs-patches(a)xemacs.org
Date: Fri, 05 Mar 99 14:41:54 +0000
Subject: Correct initial display of msw toolbars
For 21.0, and maybe 21.2.
- Phil
1999-03-05 Philip Aston <philipa(a)parallax.co.uk>
* toolbar-msw.c Consider captions when deciding whether to rebuild
toolbar. This fixes the initial toolbar display for those of us
who don't like captions.
*** src/toolbar-msw.c.old Fri Mar 05 14:13:50 1999
--- src/toolbar-msw.c Fri Mar 05 13:55:58 1999
***************
*** 205,214 ****
{
struct toolbar_button *tb = XTOOLBAR_BUTTON (button);
! checksum = HASH4 (checksum,
internal_hash (get_toolbar_button_glyph(w, tb), 0),
internal_hash (tb->callback, 0),
! width);
button = tb->next;
nbuttons++;
}
--- 205,215 ----
{
struct toolbar_button *tb = XTOOLBAR_BUTTON (button);
! checksum = HASH5 (checksum,
internal_hash (get_toolbar_button_glyph(w, tb), 0),
internal_hash (tb->callback, 0),
! width,
! w->toolbar_buttons_captioned_p);
button = tb->next;
nbuttons++;
}
[The following is probably just fixing the symptom. The problem seems
to be that mswindows_iconify_frame is never called.]
From: Philip Aston <philipa(a)parallax.co.uk>
To: xemacs-patches(a)xemacs.org
Date: Fri, 5 Mar 1999 09:39:31 +0000 (GMT-0:00)
Subject: Another msw raise frame fix.
MIME-Version: 1.0
This is for 21.0, and maybe 21.2 as well.
1999-03-05 Philip Aston <philipa(a)parallax.co.uk>
* frame-msw.c Make raise-frame restore minimised windows.
*** src/frame-msw.c.old Wed Mar 03 14:23:04 1999
--- src/frame-msw.c Wed Mar 03 14:15:40 1999
***************
*** 301,307 ****
static void
mswindows_make_frame_visible (struct frame *f)
{
! if (f->iconified)
ShowWindow (FRAME_MSWINDOWS_HANDLE(f), SW_RESTORE);
else
ShowWindow (FRAME_MSWINDOWS_HANDLE(f), SW_SHOW);
--- 301,307 ----
static void
mswindows_make_frame_visible (struct frame *f)
{
! if (IsIconic (FRAME_MSWINDOWS_HANDLE(f)))
ShowWindow (FRAME_MSWINDOWS_HANDLE(f), SW_RESTORE);
else
ShowWindow (FRAME_MSWINDOWS_HANDLE(f), SW_SHOW);
From: Philip Aston <philipa(a)parallax.co.uk>
To: xemacs-patches(a)xemacs.org
Date: Fri, 05 Mar 99 09:32:46 +0000
Subject: device-msw.c - DEFVAR format
This is for 21.0, and maybe 21.2 as well.
1999-03-05 Philip Aston <philipa(a)parallax.co.uk>
* Fix DEFVAR format - Death to phantom quote, and add magic
newline.
*** src/device-msw.c.old Thu Mar 04 20:13:06 1999
--- src/device-msw.c Thu Mar 04 20:35:28 1999
***************
*** 303,313 ****
DEFVAR_LISP ("mswindows-downcase-file-names",
&Vmswindows_downcase_file_names /*
Non-nil means convert all-upper case file names to lower case.
! This applies when performing completions and file name expansion.*/ );
Vmswindows_downcase_file_names = Qnil;
DEFVAR_LISP ("mswindows-get-true-file-attributes",
&Vmswindows_get_true_file_attributes /*
! "Non-nil means determine accurate link count in file-attributes.
This option slows down file-attributes noticeably, so is disabled by
default. Note that it is only useful for files on NTFS volumes,
where hard links are supported.
--- 303,314 ----
DEFVAR_LISP ("mswindows-downcase-file-names",
&Vmswindows_downcase_file_names /*
Non-nil means convert all-upper case file names to lower case.
! This applies when performing completions and file name expansion.
! */ );
Vmswindows_downcase_file_names = Qnil;
DEFVAR_LISP ("mswindows-get-true-file-attributes",
&Vmswindows_get_true_file_attributes /*
! Non-nil means determine accurate link count in file-attributes.
This option slows down file-attributes noticeably, so is disabled by
default. Note that it is only useful for files on NTFS volumes,
where hard links are supported.