Re: vc-revert-buffer1 sacrifices fontification preserving minor modes
>>>> "dv" == Didier Verna
<verna(a)inf.enst.fr> writes:
dv> Adrian Aichner <aichner(a)ecf.teradyne.com> writes:
> How about this patch against
> xemacs-packages\prog\vc\vc.el?
>
> It preserves minor modes AND does not lose fontification of buffer.
dv> (I don't use vc) It seems that you blindly call
The good thing about vc.el is that I have one frontend for both RCS
and CVS. For CVS I don't need to run cvs-examine to get a *cvs*
buffer to commit changes from there.
dv> font-lock-fontify-buffer. But what makes you think
dv> people always have (and will want) fontification ?
Currently vc-revert-buffer1 is plain broken, because it looses
fontification of font-locked buffers.
How about this patch instead?
Index: vc.el
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs-packages/prog/vc/vc.el,v
retrieving revision 1.8
diff -u -u -r1.8 vc.el
--- vc.el 1999/07/09 07:51:48 1.8
+++ vc.el 1999/07/26 14:25:03
＠＠ -718,6 +718,10 ＠＠
(let ((context (vc-buffer-context)))
;; t means don't call normal-mode; that's to preserve various minor modes.
(revert-buffer arg no-confirm t)
+ ;; Since we preserve-modes above, we have to fontify the buffer
+ ;; ourselves, when font-lock-mode is on.
+ (if font-lock-mode
+ (font-lock-fontify-buffer))
(vc-restore-buffer-context context)))
Regards,
Adrian