Re: [PATCH] vc.el cleanup, THE RIGHT ONE
Jan Vroonhof <vroonhof(a)math.ethz.ch> writes:
"Kirill M. Katsnelson" <kkm(a)kis.ru> writes:
> vc.el did not work on Windows in some cases, because it used /bin/sh
> to redirect stdout to a file. I changed it to use (with-temp-file)
> for the same kludgery.
Also... Please mark all you changes with a ";; XEmacs change" or
something like that. It symplifies the syncs a lot.
We should contribute these back to the main VC author... we should not
have any 'XEmacs change' items in that file. Or we'll get bitten in the
ass. :) Trust me, I was by the oddness between XEmacs VC and the core VC.
The main change I could see in VC was that we added menu support (we
should change it to use easymenu), and some bits were trying to be WAY too
smart and lost big time on files that were the result of a merge or patch
(it would not recognize them as CVS controlled files).
Let's stop the VC insanity! :)
-Bill P.