Re: Ben's Big Patch

Always ends up this way, doesn't it? I apologize to those waiting on the Mule on Windows code; I took what ended up as a 2-3 week break to put in some gui stuff i was really wanting, including dialog boxes and a bunch of stuff from an existing workspace. This code has not yet been committed; I'll do that in a day or so. BEFORE commenting on one of the items below, please read the source! ben Major UI changes: -- real file dialog boxes under Windows -- Under MS Win, keyboard traversal works in "question"-type dialog boxes [e.g. the Revert-Buffer or Save-Buffers dialog boxes] and works somewhat in general-type [currently, just the Edit->Search dialog box]. -- Help is now hyperlinkable. click on middle button or double-click of left button links to help on that variable or function, and right button brings up context menu entries allowing you to see the documentation or source on the function and/or variable at point. If the normal right button menus were specified using mode-popup-menu rather than just overriding from scratch, the context items will appear automatically at the end. -- Ctrl-T and Meta-T [capital T, with shift] move the current line one line down and are suitable for autorepeat. transpose-lines is broken twice: its binding is the nonrepeatable C-x C-t, and when you try to execute it many times, you find that the *PREVIOUS* line is the one moving up or done. -- Lisp-mode popup menu is different from menubar menu and more intelligently suited for popup use. Major Lisp changes: -- general concept of "activate" action subsumes various random button2 hacks, and you can configure the button strokes that do the activate action; currently button2-click and button1-double-click. [note that this is button2-click, not button2-down; this makes it possible to use button2-drag for something else, e.g. initiate drag-drop. button2 is now bound to mouse-track, like button1, giving you the ability to assign many different actions at once to it.] -- extents can specify context menu items, which automatically appear when you button3 on the extent. -- new generalized function make-dialog-box for dialog boxes. -- extents-at, extent-at-event, extents-at-event -- "structured errors" -- `error' is now much more powerful and its expected use is for signalling errors of a particular type, just not type `error'; a whole hierarchy of useful types has been created -- mouse events now track button modifiers as well as key modifiers -- "progress-display" renamed to "progress-feedback", and lprogress-display -> progress-feedback-with-label 2000-07-15 Ben Wing <ben(a)xemacs.org&gt; * autoload.el: Fixed comments. * cmdloop.el: * cmdloop.el (yes-or-no-p): * cmdloop.el (y-or-n-p): Make these functions use should-use-dialog-box-p and not be overridden in dialog.el. * cus-dep.el: * cus-dep.el (Custom-make-dependencies): Removed. * cus-dep.el (Custom-make-dependencies-1): New. * cus-dep.el (Custom-make-one-dependency): New. New entry point for use in Makefiles, to avoid excessive invocations. * cus-edit.el (custom-variable-reset-saved): * cus-edit.el (custom-variable-reset-standard): * cus-edit.el (custom-save-resets): Fix bytecompiler warnings. * dialog.el: * dialog.el (yes-or-no-p-dialog-box): * dialog.el (yes-or-no-p-maybe-dialog-box): Removed. * dialog.el (y-or-n-p-maybe-dialog-box): Removed. * dialog.el (get-dialog-box-response): * dialog.el (message-or-box): * dialog.el (make-dialog-box): * dialog.el (popup-dialog-box): New. Avoid yes-or-no-p bogosities. Create a general function `make-dialog-box' to encapsulate all dialog box methods; easily extendable. popup-dialog-box now obsolete. * dumped-lisp.el (preloaded-file-list): Add dialog-items. Clean up. Group files by types. * easymenu.el (easy-menu-add): * easymenu.el (easy-menu-remove): Account for accelerators. * extents.el: * extents.el (extent-list): New args, like in map-extents. * extents.el (extent-at-event): New. * extents.el (extents-at-event): New. * font-lock.el: * font-lock.el (font-lock-mode): * font-lock.el (font-lock-default-fontify-buffer): * font-lock.el (font-lock-default-unfontify-region): * font-lock.el (font-lock-fontify-syntactically-region): * font-lock.el (font-lock-fontify-keywords-region): Use new progress-feedback names. * font-lock.el (java-font-lock-identifier-regexp): * font-lock.el (java-font-lock-class-name-regexp): Fix bytecompiler warnings. * gutter-items.el: * gutter-items.el (progress-display-use-echo-area): Removed. * gutter-items.el (progress-feedback-use-echo-area): New. * gutter-items.el (progress-display-popup-period): Removed. * gutter-items.el (progress-feedback-popup-period): New. * gutter-items.el (set-progress-display-style): Removed. * gutter-items.el (set-progress-feedback-style): New. * gutter-items.el (progress-display-style): Removed. * gutter-items.el (progress-feedback-style): New. * gutter-items.el (progress-stack): * gutter-items.el (progress-displayed-p): Removed. * gutter-items.el (progress-feedbacked-p): New. * gutter-items.el (clear-progress-display): Removed. * gutter-items.el (clear-progress-feedback): New. * gutter-items.el (progress-display-clear-when-idle): Removed. * gutter-items.el (progress-feedback-clear-when-idle): New. * gutter-items.el (remove-progress-display): Removed. * gutter-items.el (remove-progress-feedback): New. * gutter-items.el (progress-display-dispatch-non-command-events): Removed. * gutter-items.el (progress-feedback-dispatch-non-command-events): New. * gutter-items.el (append-progress-display): Removed. * gutter-items.el (append-progress-feedback): New. * gutter-items.el (abort-progress-display): Removed. * gutter-items.el (abort-progress-feedback): New. * gutter-items.el (raw-append-progress-display): Removed. * gutter-items.el (raw-append-progress-feedback): New. * gutter-items.el (display-progress-display): Removed. * gutter-items.el (display-progress-feedback): New. * gutter-items.el (current-progress-display): Removed. * gutter-items.el (current-progress-feedback): New. * gutter-items.el (current-progress-display-label): Removed. * gutter-items.el (current-progress-feedback-label): New. * gutter-items.el (progress-display): Removed. * gutter-items.el (progress-feedback): New. Replace "progress-display" with "progress-feedback" globally. * gutter-items.el (lprogress-display): Removed. * gutter-items.el (progress-feedback-with-label): New. Rename lprogress-display ==> progress-feedback-with-label. * gutter-items.el (search-dialog-direction): Removed. * gutter-items.el (search-dialog-text): Removed. * gutter-items.el (search-dialog-callback): Removed. * gutter-items.el (make-search-dialog): Removed. Move to dialog-items.el. * help.el: * help.el (help-mode-quit): * help.el (mode-for-help): New. * help.el (help-sticky-window): New. * help.el (help-window-config): New. * help.el (with-displaying-help-buffer): * help.el (function-at-event): New. * help.el (help-symbol-regexp): New. * help.el (help-symbol-run-function-1): New. * help.el (help-symbol-run-function): New. * help.el (help-symbol-function-context-menu): New. * help.el (help-symbol-variable-context-menu): New. * help.el (help-symbol-function-and-variable-context-menu): New. * help.el (frob-help-extents): New. * help.el (describe-function-1): * help.el (variable-at-point): * help.el (variable-at-event): New. * help.el (describe-variable): Major overhaul. - Make functions and variables be mousable. - Middle button hyperlinks. - New context-menu entries. * keydefs.el: * keydefs.el (global-map): New key bindings to move lines up and down. * lisp-mode.el: * lisp-mode.el (construct-lisp-mode-menu): New. * lisp-mode.el (emacs-lisp-mode-popup-menu): * lisp-mode.el (lisp-interaction-mode-menubar-menu): * lisp-mode.el (emacs-lisp-mode-menubar-menu): * lisp-mode.el (lisp-indent-function): Indent "flet" entries better. Make popup and menubar menus be different. Popup menu uses clicked location and automatically assumes symbol under the mouse for various commands. * menubar-items.el: * menubar-items.el (bookmark-menu-filter): Add accelerators. * menubar-items.el (buffers-menu-omit-chars-list): Include 'd'. * menubar-items.el (global-popup-menu): Removed. * menubar-items.el (mode-popup-menu): Removed. * menubar-items.el (activate-popup-menu-hook): Removed. * menubar-items.el (popup-mode-menu): Removed. * menubar-items.el (popup-buffer-menu): Removed. * menubar-items.el (popup-menubar-menu): Removed. Move to menubar.el. * menubar.el: * menubar.el (global-popup-menu): New. * menubar.el (mode-popup-menu): New. * menubar.el (activate-popup-menu-hook): New. * menubar.el (last-popup-menu-event): New. * menubar.el (popup-mode-menu): New. * menubar.el (popup-buffer-menu): New. * menubar.el (popup-menubar-menu): New. * menubar.el (menu-call-at-event): New. Move non-content functions here. Add support for context menu items on extents. * minibuf.el (minibuffer-history-uniquify): Typo fix. * minibuf.el (read-file-name-1): Call new file dialog box if it exists. * minibuf.el (mouse-rfn-setup-vars): Clean up "chop" action. * mouse.el: * mouse.el (button2): Now bound to mouse-track. * mouse.el (click-inside-extent-p): * mouse.el (point-inside-extent-p): * mouse.el (point-inside-selection-p): * mouse.el (mouse-drag-or-yank): Removed. * mouse.el (mouse-begin-drag-n-drop): New. * mouse.el (mouse-eval-sexp): * mouse.el (mouse-track-activate-strokes): New. * mouse.el (mouse-track-do-activate): New. * mouse.el (mouse-track): * mouse.el (default-mouse-track-event-is-with-button): New. * mouse.el (default-mouse-track-cleanup-hook): * mouse.el (default-mouse-track-drag-hook): * mouse.el (default-mouse-track-drag-up-hook): * mouse.el (default-mouse-track-click-hook): Merge drag-n-drop into mouse-track. Add general "activate" support to replace specific button2 kludges. Use "button modifier" support in mouse-track. * package-get.el (package-get-dependencies): Fix bytecompiler warnings. * package-ui.el: * package-ui.el (pui-menu): * package-ui.el (pui-popup-context-sensitive): Removed. Fix bytecompiler warnings. Clean up popup code a bit. * select.el (get-selection-no-error): Fix bytecompiler warnings. * simple.el: * simple.el (transpose-lines): * simple.el (transpose-line-up): New. * simple.el (transpose-line-down): New. * simple.el (transpose-subr): * simple.el (transpose-subr-1): Removed. Clean up, add functions to move lines up and down. * startup.el (mail-host-address): * startup.el (user-mail-address): Customize. * subr.el: * subr.el (set-symbol-value-in-buffer): New. * subr.el (error): * subr.el (check-argument-type): * subr.el (defined-error-p): New. Add structured error support. * toolbar-items.el (toolbar-compile): Use new make-dialog-box. * update-elc.el: * userlock.el (ask-user-about-lock-dbox): * userlock.el (ask-user-about-supersession-threat-dbox): * userlock.el (ask-user-about-lock): * userlock.el (ask-user-about-supersession-threat): Use new make-dialog-box. Add safety checks; use should use-dialog-box-p. * window-xemacs.el: * window-xemacs.el (__buffer-dedicated-frame): * window-xemacs.el (buffer-dedicated-frame): New. * window-xemacs.el (set-buffer-dedicated-frame): New. Move dedicated-frame stuff into lisp. 2000-07-15 Ben Wing <ben(a)xemacs.org&gt; * s/cygwin32.h: * s/cygwin32.h (CYGWIN_CONV_PATH): Add missing logb prototype for v1.1. Use post-b20 names and alias to pre-b20 names when pre-b20. * s/windowsnt.h: [5]. 2000-07-15 Ben Wing <ben(a)xemacs.org&gt; * Makefile.in.in (x_objs): * Makefile.in.in (sheap_objs): * Makefile.in.in (objs): added win32.o, cosmetic cleanups. * alloc.c (Fmake_byte_code): [[[1]]]: Changes for new LIST_LOOP, EXTERNAL_LIST_LOOP, etc. macros which declare their own args now. * alloc.c (syms_of_alloc): [[[2]]]: Use DEFSYMBOL, DEFKEYWORD, DEFERROR and friends. * buffer.c: Moved buffer-dedicated-frame, set-buffer-dedicated-frame into lisp. * buffer.c (Fget_file_buffer): Fixed GCPRO problem. * buffer.c (get_truename_buffer): Fixed comment about GC checking. * buffer.c (syms_of_buffer): Undeclared those dedicated frame funs. [2]. * buffer.h: Define convenience macros for internal/external conversions. [[[3]]]: Define codesys aliases Qcommand_argument_encoding and Qenvironment_variable_encoding for cleaner code. * bufslots.h: Remove dedicated-frame; in lisp. * bytecode.c (funcall_compiled_function): [1]. * bytecode.c (syms_of_bytecode): [2]. * console-msw.c: * console-msw.c (mswindows_show_console): Rewrote. * console-msw.c (Fmswindows_debugging_output): New. Sends to OutputDebugString (special MSWin debugger interface). * console-msw.c (Fmswindows_message_box): Fixed stupid bugs so it works when called from kill-emacs. * console-msw.c (syms_of_console_mswindows): Declare Fmswindows_debugging_output. * console-msw.h: New MSWin prototypes. * console-msw.h (struct mswindows_frame): New entry last-click-mods for improved button-modifier support. * console-msw.h (FRAME_MSWINDOWS_POPUP): New struct entry `popup' with corresponding accessor. * console-x.c: * console-x.c (split_up_display_spec): * console-x.c (get_display_arg_connection): * console-x.c (x_semi_canonicalize_console_connection): * console-x.c (x_canonicalize_device_connection): [[[6]]]: Change char to more specific type. [[[8]]]: Make use of abstracting codesys aliases defined in [3], [4]; * console-x.c (x_semi_canonicalize_console_connection): * console-x.c (x_canonicalize_device_connection): [[[9]]]: Fix up error signalling to use new structured error system. * console-x.h: [[[4]]]: Define codesys aliases: Qlwlib_encoding, Qx_atom_name_encoding, Qx_font_name_encoding, Qx_color_name_encoding, Qx_display_name_encoding. * console.h (struct console_methods): New method make_dialog_box_internal supersedes older popup_dialog_box method. * data.c: Define many new errors, part of new structured errors. * data.c (init_errors_once_early): * data.c (syms_of_data): [2]. * device-msw.c (mswindows_init_device): [[[5]]]: Cleanup to support NT 3.51. * device-msw.c (decode_devmode): Cleanup. * device-msw.c (mswindows_handle_print_setup_dialog_box): * device-msw.c (mswindows_handle_print_dialog_box): * device-msw.c (mswindows_handle_page_setup_dialog_box): * device-msw.c (syms_of_device_mswindows): Delete the dialog box primitives recently introduced by Kirill and instead interface to general dialog box interface. * device-x.c: * device-x.c (compute_x_app_name): * device-x.c (x_init_device): * device-x.c (Fx_valid_keysym_name_p): * device-x.c (Fx_set_font_path): [6]. [7]. * device.h (wrap_device): New. First of its kind; meant to replace XSETDEVICE. * dialog-msw.c: Many file-dialog symbols. * dialog-msw.c (mswindows_register_popup_frame): New. * dialog-msw.c (mswindows_is_dialog_msg): New. For supporting kbd traversal in dialog boxes. * dialog-msw.c (dialog_proc): Support hitting ESC in dialogs. * dialog-msw.c (struct): Common dialog box errors. * dialog-msw.c (handle_file_dialog_box): New. Add file dialog code. * dialog-msw.c (handle_question_dialog_box): Redo existing code to support new question dialog syntax. * dialog-msw.c (console_type_create_dialog_mswindows): We support new dialog console method. * dialog-msw.c (syms_of_dialog_mswindows): * dialog-msw.c (vars_of_dialog_mswindows): New file dialog symbols, vars. * dialog-x.c: * dialog-x.c (maybe_run_dbox_text_callback): * dialog-x.c (dbox_descriptor_to_widget_value): * dialog-x.c (x_make_dialog_box_internal): * dialog-x.c (console_type_create_dialog_x): Mule-ize entire file. Redo to support question dialog syntax. [6]. * dialog.c: * dialog.c (Fmake_dialog_box_internal): * dialog.c (syms_of_dialog): Kill old popup-dialog-box, replace with new primitive. Just call device method or signal error. * eldap.c (Fldap_open): * eldap.c (Fldap_search_basic): * eldap.c (Fldap_add): * eldap.c (Fldap_modify): [1]. [7]. * emacs.c: * emacs.c (make_arg_list_1): * emacs.c (make_arg_list): Mule-ize call to dll_init(). [6]. [8]. * emacs.c (make_argc_argv): * emacs.c (free_argc_argv): * emacs.c (init_cmdargs): * emacs.c (main_1): * emacs.c (Fkill_emacs): * emacs.c (Fdump_emacs): Update comments about what can be used in syms_* etc. Call init_win32() when necessary. Fix up MS Win dialog box in kill-buffer to actually work right. [7]. * eval.c: * eval.c (For): * eval.c (Fand): * eval.c (Fprogn): * eval.c (Fprog1): * eval.c (Fprog2): * eval.c (FletX): * eval.c (Flet): * eval.c (condition_case_3): * eval.c (Feval): * eval.c (function_argcount): * eval.c (funcall_lambda): [1]. * eval.c (type_error): New. * eval.c (maybe_type_error): New. * eval.c (continuable_type_error): New. * eval.c (maybe_continuable_type_error): New. * eval.c (type_error_with_frob): New. * eval.c (maybe_type_error_with_frob): New. * eval.c (continuable_type_error_with_frob): New. * eval.c (maybe_continuable_type_error_with_frob): New. New functions for use with structured errors. * event-Xt.c: * event-Xt.c (x_event_to_emacs_event): Buttons are now modifiers too. * event-Xt.c (emacs_Xt_current_event_timestamp): Implement new event method. * event-Xt.c (reinit_vars_of_event_Xt): Set it. * event-msw.c: * event-msw.c (ntpipe_shove_writer): [5]. * event-msw.c (mswindows_enqueue_mouse_button_event): * event-msw.c (mswindows_drain_windows_queue): * event-msw.c (mswindows_wnd_proc): [7]. * event-msw.c (mswindows_current_layout_has_AltGr): [5]. * event-msw.c (mswindows_modifier_state): Throughout: support new button modifiers. * event-msw.c (emacs_mswindows_current_event_timestamp): Implement new event method. * event-msw.c (reinit_vars_of_event_mswindows): Set it. * event-stream.c: * event-stream.c (event_stream_current_event_timestamp): New. * event-stream.c (maybe_kbd_translate): New functionality. * event-stream.c (vars_of_event_stream): Document new kbd-translate-table functionality. * event-stream.c (Fcurrent_event_timestamp): New. New primitive for use in fabricated events. * event-stream.c (syms_of_event_stream): [2]. Declare new primitive. * events-mod.h (XEMACS_MOD_BUTTON1): new button modifiers. * events.c: * events.c (Fmake_event): * events.c (WRONG_EVENT_TYPE_FOR_PROPERTY): [1]. [9]. * events.c (format_event_object): fix gcc warnings. * events.c (Fevent_timestamp): Document new primitives. * events.c (TIMESTAMP_HALFSPACE): New. * events.c (Fevent_timestamp_lessp): New. New primitive for comparing timestamps correctly (half-space algorithm). * events.c (Fevent_modifier_bits): Doc fix. * events.c (Fevent_modifiers): Major doc addition. * events.c (event_x_y_pixel_internal): Typo fix. * events.c (syms_of_events): Declare new primitives. * events.h: Update long comment for button modifiers, timestamps. * events.h (struct event_stream): New current_event_timestamp method. * extents.c: * extents.c (extent_in_region_p): * extents.c (decode_extent): * extents.c (Fset_extent_parent): * extents.c (decode_map_extents_flags): Fix gcc warnings. [9]. * extents.c (struct extent_at_arg): * extents.c (decode_extent_at_flag): * extents.c (extent_at_mapper): * extents.c (extent_at_bytind): * extents.c (Fextent_at): Adapt to new lower-level interface. [9]. * extents.c (Fextents_at): New primitive. [9]. * extents.c (symbol_to_glyph_layout): [9]. Support new primitive `extents-at'. * extents.c (get_text_property_bytind): extent_at_bytind has another arg. [9]. * extents.c (syms_of_extents): New primitive. * file-coding.c (Fmake_coding_system): [1]. * file-coding.c (subsidiary_coding_system): fix gcc warning * file-coding.c (syms_of_file_coding): [2]. * fileio.c (Fexpand_file_name): * fileio.c (Fsysnetunam): * fileio.c (Ffile_exists_p): * fileio.c (Ffile_executable_p): * fileio.c (Fverify_visited_file_modtime): Clean up GCPROing. * fileio.c (syms_of_fileio): [2]. * filelock.c (lock_file_1): * filelock.c (current_lock_owner): * filelock.c (lock_if_free): * filelock.c (lock_file): * filelock.c (unlock_file): Clean up GCPROing. * fns.c (concat): Fix gcc warning. * fns.c (Fmember): * fns.c (Fold_member): * fns.c (Fmemq): * fns.c (Fold_memq): * fns.c (memq_no_quit): * fns.c (Fassoc): * fns.c (Fold_assoc): * fns.c (Fassq): * fns.c (Fold_assq): * fns.c (assq_no_quit): * fns.c (Frassoc): * fns.c (Fold_rassoc): * fns.c (Frassq): * fns.c (Fold_rassq): * fns.c (rassq_no_quit): * fns.c (Fdelete): * fns.c (Fold_delete): * fns.c (Fdelq): * fns.c (Fold_delq): * fns.c (delq_no_quit): * fns.c (Fremassoc): * fns.c (Fremassq): * fns.c (remassq_no_quit): * fns.c (Fremrassoc): * fns.c (Fremrassq): * fns.c (remrassq_no_quit): * fns.c (Freverse): * fns.c (mapcar1): [1]. * frame-msw.c (mswindows_init_frame_1): * frame-msw.c (mswindows_delete_frame): Register popups with dialog code so keyboard traversing works. * frame-tty.c (tty_raise_frame_no_select): [1]. * frame-x.c: * frame-x.c (x_set_frame_text_value): * frame-x.c (x_set_frame_properties): * frame-x.c (x_create_widgets): [7]. * frame.c: * frame.c (Fmouse_pixel_position): Minor doc fixes. * frame.h (wrap_frame): New. Macro like wrap_device. * general.c: * general.c (SYMBOL): * general.c (syms_of_general): Major reorg. This is now just a wrapper and symbols themselves are listed in general-slots.h. * glyphs-eimage.c (tiff_instantiate): Need cast to fix warning. * glyphs-msw.c (mswindows_resource_instantiate): [5]. * glyphs-msw.c (mswindows_native_layout_instantiate): Add DS_CONTROL so keyboard traversal will work. * glyphs-widget.c: * glyphs-widget.c (syms_of_glyphs_widget): Move some symbols to general-slots.h. * glyphs-x.c: * glyphs-x.c (xbm_instantiate_1): * glyphs-x.c (x_xbm_instantiate): * glyphs-x.c (x_xface_instantiate): * glyphs-x.c (autodetect_instantiate): * glyphs-x.c (cursor_font_instantiate): * glyphs-x.c (x_update_widget): * glyphs-x.c (x_widget_instantiate): * glyphs.c (bitmap_to_lisp_data): * glyphs.c (pixmap_to_lisp_data): [7]. * glyphs.c (syms_of_glyphs): [2]. * gui-x.c: * gui-x.c (print_widget_value): * gui-x.c (menu_separator_style_and_to_external): * gui-x.c (add_accel_and_to_external): * gui-x.c (button_item_to_widget_value): * gui-x.c (gui_items_to_widget_values_1): * gui-x.c (gui_items_to_widget_values): * gui-x.c (syms_of_gui_x): * gui-x.c (vars_of_gui_x): Mule-ize entire file. Move menu-no-selection-hook to gui.c. [9]. * gui-x.h: Muleize, prototype changes matching gui-x.c. * gui.c: * gui.c (separator_string_p): * gui.c (gui_item_add_keyval_pair): * gui.c (make_gui_item_from_keywords_internal): * gui.c (signal_too_long_error): * gui.c (parse_gui_item_tree_item): * gui.c (syms_of_gui): * gui.c (vars_of_gui): * gui.h: menu-no-selection-hook moved here (used by MSWin). Move some symbols to general-slots.h. [6]. [9]. * insdel.c (get_buffer_pos_char): * insdel.c (get_buffer_range_char): Add GC comments. * keymap.c (keymap_lookup_directly): * keymap.c (keymap_store): * keymap.c (ensure_meta_prefix_char_keymapp): * keymap.c (describe_map): * keymap.h: Support new button modifiers. * lisp-disunion.h (wrap_object): * lisp-disunion.h (XSETOBJ): Rename make_obj to wrap_object. * lisp-union.h: * lisp-union.h (make_int): * lisp-union.h (make_char): Support wrap_object. * lisp.h: * lisp.h (LIST_LOOP): * lisp.h (EXTERNAL_LIST_LOOP): * lisp.h (LIST_LOOP_2): * lisp.h (EXTERNAL_LIST_LOOP_1): * lisp.h (EXTERNAL_LIST_LOOP_2): * lisp.h (EXTERNAL_LIST_LOOP_3): * lisp.h (EXTERNAL_LIST_LOOP_4_NO_DECLARE): * lisp.h (PRIVATE_EXTERNAL_LIST_LOOP_6): * lisp.h (GET_EXTERNAL_LIST_LENGTH): * lisp.h (EXTERNAL_ALIST_LOOP_5): * lisp.h (EXTERNAL_ALIST_LOOP_6): * lisp.h (EXTERNAL_ALIST_LOOP_6_NO_DECLARE): * lisp.h (EXTERNAL_PROPERTY_LIST_LOOP_5_NO_DECLARE): * lisp.h (EXTERNAL_PROPERTY_LIST_LOOP_7): * lisp.h (struct Lisp_Symbol): * lisp.h (maybe_continuable_error_with_frob): Fix up section comments. Add new types for char to indicate usage. Delete symbols auto-generated from general-slots.h. Add prototypes for structured error functions. Add long comments describing looping macros and change interface so that lvalues are automatically declared. Add NO_DECLARE macro in case callers want to declare lvalues themselves. * lread.c (read_syntax_error): * lread.c (continuable_read_syntax_error): * lread.c (read_structure): * lread.c (sequence_reader): * lread.c (read_list_conser): * lread.c (read_compiled_function): Rename syntax_error and continuable_syntax_error to avoid clash with same-named structured error functions. * menubar-msw.c (mswindows_translate_menu_or_dialog_item): * menubar-msw.c (populate_menu_add_item): * menubar-msw.c (populate_or_checksum_helper): [5]. [9]. * menubar-x.c: * menubar-x.c (menu_item_descriptor_to_widget_value_1): Mule-ize whole file. * menubar.c (Fnormalize_menu_item_name): Add optimization. * mule-charset.c (Fmake_charset): * mule-wnnfns.c (Fwnn_set_param): [1]. * ntproc.c (create_child): * ntproc.c (Fwin32_set_current_locale): Add comments portending doom. * objects-msw.c: * objects-msw.c (old_font_enum_callback_2): * objects-msw.c (font_enum_callback_1): * objects-msw.c (mswindows_enumerate_fonts): [5]. * objects-x.c: * objects-x.c (allocate_nearest_color): * objects-x.c (x_parse_nearest_color): * objects-x.c (x_initialize_color_instance): * objects-x.c (x_print_color_instance): * objects-x.c (x_finalize_color_instance): * objects-x.c (x_valid_color_name_p): * objects-x.c (x_initialize_font_instance): * objects-x.c (x_print_font_instance): * objects-x.c (valid_x_font_name_p): * objects-x.c (truename_via_FONT_prop): * objects-x.c (truename_via_random_props): * objects-x.c (truename_via_XListFonts): * objects-x.c (x_font_truename): * objects-x.c (x_font_instance_truename): * objects-x.c (x_font_instance_properties): * objects-x.c (x_list_fonts): * objects-x.c (x_find_charset_font): Mule-ize entire file. [7]. * objects-x.h: Mule-verify. * print.c: * print.c (std_handle_out_external): * print.c (debug_print_no_newline): * print.c (syms_of_print): Output to all debugger kinds in debug-print. Fix console-output code under MSWin to actually work. * process-nt.c (send_signal): * process-nt.c (nt_create_process): Use newer Unicode macros. * process-unix.c (unix_create_process): * process-unix.c (unix_canonicalize_host_name): * process-unix.c (unix_open_network_stream): [7]. * scrollbar-x.c: Mule-verify. * search.c (syms_of_search): [2]. * select-msw.c (mswindows_destroy_selection): Use LIST_LOOP_2. * select-x.c (symbol_to_x_atom): [7]. * select.c (syms_of_select): [2]. * sound.c (Fplay_sound_file): [7]. * specifier.c: * specifier.c (decode_specifier_type): * specifier.c (Fvalid_specifier_locale_type_p): * specifier.c (check_valid_locale_or_locale_type): * specifier.c (decode_locale): * specifier.c (decode_locale_type): * specifier.c (decode_locale_list): * specifier.c (check_valid_domain): * specifier.c (decode_specifier_tag_set): * specifier.c (Fcanonicalize_tag_set): * specifier.c (Fdefine_specifier_tag): * specifier.c (Fspecifier_tag_predicate): * specifier.c (check_valid_inst_list): * specifier.c (check_valid_spec_list): * specifier.c (decode_how_to_add_specification): * specifier.c (check_modifiable_specifier): * specifier.c (specifier_add_spec): * specifier.c (boolean_validate): * specifier.c (display_table_validate): [9]. * specifier.c (syms_of_specifier): Move some symbols to general-slots.h. [2]. * symbols.c: * symbols.c (Fmapatoms): * symbols.c (Fapropos_internal): Add GCPROs. * symbols.c (set_default_buffer_slot_variable): * symbols.c (set_default_console_slot_variable): [1]. * symbols.c (defsymbol_massage_name_1): * symbols.c (defkeyword_massage_name): * symbols.c (deferror_1): * symbols.c (deferror): * symbols.c (deferror_massage_name_and_message): * symeval.h: * symeval.h (DEFSYMBOL): Support DEFSYMBOL*, DEFKEYWORD, DEFERROR * symbols.c (syms_of_symbols): [2]. * symsinit.h: * symsinit.h (init_win32): New. Also new is syms_of_dialog_mswindows. * syswindows.h: Add new Unicode macros, missing Cygwin wide-char functions, convenience conversion macros for Qmswindows_tstr, macros for encapsulating required MSWin <-> Cygwin filename conversions, prototype for dynamically-extracted (not in NT 3.51) functions. * toolbar-x.c: Mule-verify. * tooltalk.c (Fadd_tooltalk_message_arg): * tooltalk.c (Fadd_tooltalk_pattern_attribute): * tooltalk.c (Fadd_tooltalk_pattern_arg): [7]. * tooltalk.c (syms_of_tooltalk): [2]. * unexnt.c: * unexnt.c (unexec): Fix up headers, declaration of unexec() to be more standard. -- Ben In order to save my hands, I am cutting back on my mail. I also write as succinctly as possible -- please don't be offended. If you send me mail, you _will_ get a response, but please be patient, especially for XEmacs-related mail. If you need an immediate response and it is not apparent in your message, please say so. Thanks for your understanding. See also http://www.666.com/ben/chronic-pain/