Re: Some gui cleanups
Andy Piper wrote:
At 05:58 PM 4/16/00 -0700, Ben Wing wrote:
>"i don't feel like making the effort" isn't a very good excuse.
If XEmacs was my full time job, maybe. But actually I *don't* feel like
making the effort. Supporting Athena *at all* has been a tremendous pain
for me. If you would rather I stop that suits me just fine.
>it's very simple -- you defined the glyph widget api, including the :callback
>keyword, so you can change it. none of your api is set in stone. you
yourself
>the only difference is that instead of calling "Feval", call
"call2".
This makes widget callbacks different from menubar and other callbacks. I
don't think this is user friendly and in fact breaks abstraction IMO. Feval
is not called in all cases - sometimes Fcall_interactively is used. I think
the fact that you can just drop an existing function in as a callback is a
Good Thing, so I think your latest suggestion is "unclean". Changing
widget-callback-current-channel to a function is probably an ok thing to do.
I am completely vetoing widget-callback-current-channel. How about you create
a new keyword, :new-callback, that is a function of two args, like i specified
before.
btw if you really are calling your callback using call-interactively, why don't
you declare
a function (interactive "e") and then call event-channel on the resulting
event?
that should
get you the same result as widget-callback-current-channel.
the problem with this and everything you've proposed is that there's no way, of
course,
to get at the actual widget that you were invoked from. would you propose adding
widget-callback-current-widget?
andy
--------------------------------------------------------------
Dr Andy Piper
Principal Consultant, BEA Systems Ltd
--
Ben
In order to save my hands, I am cutting back on my mail. I also write
as succinctly as possible -- please don't be offended. If you send me
mail, you _will_ get a response, but please be patient, especially for
XEmacs-related mail. If you need an immediate response and it is not
apparent in your message, please say so. Thanks for your understanding.
See also http://www.666.com/ben/typing.html.