Re: [PATCH] Frame crash and extra minibuffers fixes
Greg Klanderman <greg(a)alphatech.com> writes:
>>>>> "kkm" == Kirill M Katsnelson
<kkm(a)kis.ru> writes:
kkm>
kkm> This fixes [very probable cause for] crashes seen by Karl and Greg,
kkm> and solves extra minibuffers problem in ediff, reported by Greg.
Thanks Kirill! That does it. BTW, this appears to be the ChangeLog
entry you were looking for:
> 1998-03-17 SL Baur <steve(a)altair.xemacs.org>
>
> * frame.c (delete_frame_internal): Correct check.
Steve, was this to fix a bug or did it just look wrong?
It was to fix a bug. `called_from_delete_device' can never be less
than 0 so it is a degenerate comparison.
I see nowhere that function is called with other than 0 or 1,
so maybe this code should just be ifdef'd out or removed?
Yes, reversing the patch I made is equivalent to `if (1)' so there
little point to keeping that conditional if it is causing problems.