gutter-items loses again

gutter-items.el is initializing itself too early. This code probably belongs on the `window-setup-hook', it definitely should not be executed when dumping. A proposed patch is attached. (The void function problem is a totally separate issue and unrelated to gutter-items.el itself). Loading gutter-items.el...*** Error in XEmacs initialization (void-function buffers-menu-omit-invisible-buffers) *** Backtrace really-early-error-handler((void-function buffers-menu-omit-invisible-buffers)) buffers-menu-omit-invisible-buffers(#<buffer "*scratch*">) funcall(buffers-menu-omit-invisible-buffers #<buffer "*scratch*">) (not (funcall cl-if (cl-check-key ...))) ) (eq (not (funcall cl-if ...)) cl-if-not) ) (cond (cl-test (eq ... cl-test-not)) (cl-if (eq ... cl-if-not)) (t (if ... ... ...))) ) (cl-check-test-nokey cl-item (cl-check-key (car cl-seq))) ) (cl-check-test cl-item (car cl-seq)) ) (and cl-seq (> cl-end 0) (cl-check-test cl-item (car cl-seq)) (setq cl-end (1- cl-end) cl-seq (cdr cl-seq)) (> (setq cl-count ...) 0)) ) (while (and cl-seq (> cl-end 0) (cl-check-test cl-item ...) (setq cl-end ... cl-seq ...) (> ... 0))) ) (progn (while (and cl-seq ... ... ... ...)) (setq cl-end (1- cl-end))) ) (if (= cl-start 0) (progn (while ...) (setq cl-end ...)) (setq cl-start (1- cl-start))) ) (if (and cl-from-end (< cl-count 4000000)) (let (cl-i) (while ... ... ...) cl-seq) (setq cl-end (- ... cl-start)) (if (= cl-start 0) (progn ... ...) (setq cl-start ...)) (if (and ... ...) (let ... ...)) cl-seq) ) (if (listp cl-seq) (if (and cl-from-end ...) (let ... ... cl-seq) (setq cl-end ...) (if ... ... ...) (if ... ...) cl-seq) (apply (quote remove*) cl-item cl-seq cl-keys)) ) (if (<= (or cl-count ...) 0) cl-seq (if (listp cl-seq) (if ... ... ... ... ... cl-seq) (apply ... cl-item cl-seq cl-keys))) ) # bind (cl-end cl-start cl-from-end cl-count cl-if-not cl-if cl-key cl-test-not cl-test) (let* ((cl-test ...) (cl-test-not ...) (cl-key ...) (cl-if ...) (cl-if-not ...) (cl-count ...) (cl-from-end ...) (cl-start ...) (cl-end ...)) (let (...) (while cl-keys-temp ... ...)) (if (<= ... 0) cl-seq (if ... ... ...))) ) (cl-parsing-keywords (:test :test-not :key :if :if-not :count :from-end (:start 0) :end) nil (if (<= ... 0) cl-seq (if ... ... ...))) ) # bind (cl-keys cl-seq cl-item) delete*(nil (#<buffer "*scratch*"> #<buffer " *Minibuf-0*"> #<buffer " *Echo Area*"> #<buffer " *pixmap conversion*"> #<buffer " *load*">) :if buffers-menu-omit-invisible-buffers) apply(delete* nil (#<buffer "*scratch*"> #<buffer " *Minibuf-0*"> #<buffer " *Echo Area*"> #<buffer " *pixmap conversion*"> #<buffer " *load*">) :if buffers-menu-omit-invisible-buffers nil) # bind (cl-keys cl-list cl-pred) delete-if(buffers-menu-omit-invisible-buffers (#<buffer "*scratch*"> #<buffer " *Minibuf-0*"> #<buffer " *Echo Area*"> #<buffer " *pixmap conversion*"> #<buffer " *load*">)) (let ((buffers ...)) (and (integerp buffers-tab-max-size) (> buffers-tab-max-size 1) (> ... buffers-tab-max-size) (setcdr ... nil)) (setq buffers (build-buffers-tab-internal buffers)) buffers) ) buffers-tab-items() (list :items (buffers-tab-items)) ) (vector (quote tab-control) :descriptor "Buffers" :properties (list :items (buffers-tab-items))) ) (make-glyph (vector (quote tab-control) :descriptor "Buffers" :properties (list :items ...))) ) (setq gutter-buffers-tab (make-glyph (vector ... :descriptor "Buffers" :properties ...))) ) (set-extent-begin-glyph (make-extent 0 0 gutter-string) (setq gutter-buffers-tab (make-glyph ...))) ) # bind (gutter-string) (let ((gutter-string "")) (set-extent-begin-glyph (make-extent 0 0 gutter-string) (setq gutter-buffers-tab ...)) (set-specifier default-gutter-border-width 0 (quote global) (quote mswindows)) (set-specifier default-gutter gutter-string (quote global) (quote mswindows))) ) add-tab-to-gutter() # bind (current-load-list) # (unwind-protect ...) # bind (load-file-name) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) load-internal("/usr/local/infodock/infodock/build/sparc-sun-solaris/lisp/gutter-items.el" nil nil nil undecided) (if (or (<= ... 0) (null ...)) (and (null noerror) (signal ... ...)) (load-internal file noerror nomessage nosuffix (let ... ...))) ) (if handler (funcall handler (quote load) filename noerror nomessage nosuffix) (if (or ... ...) (and ... ...) (load-internal file noerror nomessage nosuffix ...))) ) # bind (path handler filename) (let* ((filename ...) (handler ...) (path nil)) (if handler (funcall handler ... filename noerror nomessage nosuffix) (if ... ... ...))) ) # bind (nosuffix nomessage noerror file) load("/usr/local/infodock/infodock/build/sparc-sun-solaris/lisp/gutter-items.el") (prog1 (load full-path) (garbage-collect)) ) (if full-path (prog1 (load full-path) (garbage-collect)) (external-debugging-output (format "\nLoad file %s: not found\n" file)) nil) ) # bind (full-path) (let ((full-path ...)) (if full-path (prog1 ... ...) (external-debugging-output ...) nil)) ) # bind (file) pureload("gutter-items") (if (pureload file) nil (external-debugging-output "Fatal error during load, aborting") (kill-emacs 1)) ) (unless (pureload file) (external-debugging-output "Fatal error during load, aborting") (kill-emacs 1)) ) (while (setq file (car files)) (unless (pureload file) (external-debugging-output "Fatal error during load, aborting") (kill-emacs 1)) (setq files (cdr files))) ) # bind (file files) (let ((files preloaded-file-list) file) (while (setq file ...) (unless ... ... ...) (setq files ...)) (when (not ...) (defun toolbar-button-p ... "No toolbar support." nil) (defun toolbar-specifier-p ... "No toolbar support." nil)) (fmakunbound (quote pureload))) ) (lambda nil (setq Installation-string (save-current-buffer ... ... ... ... ...)) (setq load-path (split-path ...)) (setq module-load-path (split-path ...)) (external-debugging-output (format "\nUsing load-path %s" load-path)) (external-debugging-output (format "\nUsing module-load-path %s" module-load-path)) (buffer-disable-undo (get-buffer "*scratch*")) (load "very-early-lisp" nil t) (let (...) (setq load-path ...)) (setq load-warn-when-source-newer t load-warn-when-source-only t) (defun pureload (file) (let ... ...)) (load (expand-file-name "../lisp/dumped-lisp.el")) (let (... file) (while ... ... ...) (when ... ... ...) (fmakunbound ...)) (packages-load-package-dumped-lisps late-package-load-path))() # (unwind-protect ...) call-with-condition-handler(really-early-error-handler (lambda nil (setq Installation-string (save-current-buffer ... ... ... ... ...)) (setq load-path (split-path ...)) (setq module-load-path (split-path ...)) (external-debugging-output (format "\nUsing load-path %s" load-path)) (external-debugging-output (format "\nUsing module-load-path %s" module-load-path)) (buffer-disable-undo (get-buffer "*scratch*")) (load "very-early-lisp" nil t) (let (...) (setq load-path ...)) (setq load-warn-when-source-newer t load-warn-when-source-only t) (defun pureload (file) (let ... ...)) (load (expand-file-name "../lisp/dumped-lisp.el")) (let (... file) (while ... ... ...) (when ... ... ...) (fmakunbound ...)) (packages-load-package-dumped-lisps late-package-load-path))) # bind (gc-cons-threshold) (let ((gc-cons-threshold 30000)) (call-with-condition-handler (quote really-early-error-handler) (function ...)) (setq preloaded-file-list (mapcar ... preloaded-file-list)) (setq load-warn-when-source-newer t load-warn-when-source-only nil) (setq debugger (quote debug)) (when (member "no-site-file" command-line-args) (setq site-start-file nil)) (when (load "site-load" t) (garbage-collect)) (when purify-flag (message "Finding pointers to doc strings...") (Snarf-documentation "DOC") (message "Finding pointers to doc strings...done") (Verify-documentation)) (when (stringp site-start-file) (load "site-init" t)) (setq current-load-list nil) (garbage-collect) (buffer-enable-undo "*scratch*")) ) # bind (current-load-list) # (unwind-protect ...) # bind (load-file-name) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) load("loadup.el") # bind (purify-flag load-ignore-elc-files) (let ((load-ignore-elc-files t) (purify-flag nil)) (load "loadup.el")) ) # bind (current-load-list) # (unwind-protect ...) # bind (load-file-name) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) load("loadup-el.el") (progn (setq command-line-args (append ... update-elc-files-to-compile)) (load "loadup-el.el")) ) (if update-elc-files-to-compile (progn (setq command-line-args ...) (load "loadup-el.el")) ( script done on Mon Jul 26 16:46:17 1999 1999-07-26 SL Baur <steve(a)beopen.com&gt; * gutter-items.el (window-setup-hook): Move initialization here. Index: lisp/gutter-items.el =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/lisp/Attic/gutter-items.el,v retrieving revision 1.1.2.4 diff -u -r1.1.2.4 gutter-items.el --- lisp/gutter-items.el 1999/07/25 19:16:44 1.1.2.4 +++ lisp/gutter-items.el 1999/07/26 08:38:32 ＠＠ -152,7 +152,7 ＠＠ (resize-subwindow (glyph-image-instance gutter-buffers-tab) (gutter-pixel-width) nil))) -(add-tab-to-gutter) +(add-hook 'window-setup-hook 'add-tab-to-gutter) (add-hook 'switch-to-buffer-hooks 'update-tab-in-gutter) (add-hook 'create-frame-hook 'update-tab-in-gutter)