Re: Patches to pcl-cvs-2.9.7
(cvs-file-delete): 1.72 New. Remove unnecessary files
easily.
What does it do that `cvs-mode-remove' doesn't ?
There is also problem with Win32:
This problem has been fixed by simply not passing the "." argument
(see sample quick-fix below)
If there is anywhere a double quote in the commit buffer, the
cvs.exe breaks
If it possible to add a pre-check for double quotes and refuse to run
cvs-do-commit before the double quotes have been removed?
This must be a bug with `start-process' under Losedows.
It might depend on the variant/version of Emacs you use as well as on
the shell settings since I believe that `start-process' uses a shell.
I have no time for working around bugs like that, especially since I'd
have to make it system-dependent (it works perfectly fine under Unix
and I want to be able to put double quotes in my messages).
Note that the "." problem is also a bug in losedows (but a CVS bug
this time), but it happens to be that I think it's better to not pass
any argument rather than to pass ".", and the fix is not system-dependent.
+(defun cvs-win32-p () ;; Copy from tinyliba.el
The chance of me putting such a function in PCL-CVS is about as close to zero
as it gets (and `cvs-unix-p' is just as unlikely). It's much better to
just try things out and see if they work or not.
Stefan
Index: pcl-cvs.el
===================================================================
RCS file: /home/monnier/cvsroot/elisp/pcl-cvs/pcl-cvs.el,v
retrieving revision 1.72
diff -u -r1.72 pcl-cvs.el
--- pcl-cvs.el 1999/09/05 20:21:54 1.72
+++ pcl-cvs.el 1999/10/21 02:08:15
＠＠ -815,8 +830,7 ＠＠
(cvs-flags-query 'cvs-update-flags "cvs -n update flags")))
(when (eq flags t)
(setf flags (cvs-flags-query 'cvs-update-flags nil 'noquery)))
- (cvs-cmd-do "update" directory flags
- (list (cvs-create-fileinfo 'DIRCHANGE "" "."
""))
+ (cvs-cmd-do "update" directory flags nil
(> (prefix-numeric-value current-prefix-arg) 8)
:cvsargs '("-n")
:noshow noshow
＠＠ -834,8 +848,7 ＠＠
(cvs-flags-query 'cvs-update-flags "cvs update flags")))
(when (eq flags t)
(setf flags (cvs-flags-query 'cvs-update-flags nil 'noquery)))
- (cvs-cmd-do "update" directory flags
- (list (cvs-create-fileinfo 'DIRCHANGE "" "."
""))
+ (cvs-cmd-do "update" directory flags nil
(> (prefix-numeric-value current-prefix-arg) 8)))
＠＠ -851,8 +864,7 ＠＠
(cvs-flags-query 'cvs-status-flags "cvs status flags")))
(when (eq flags t)
(setf flags (cvs-flags-query 'cvs-status-flags nil 'noquery)))
- (cvs-cmd-do "status" directory flags
- (list (cvs-create-fileinfo 'DIRCHANGE "" "."
""))
+ (cvs-cmd-do "status" directory flags nil
(> (prefix-numeric-value current-prefix-arg) 8)
:noshow noshow :dont-change-disc t))
＠＠ -1198,7 +1210,7 ＠＠
(defun-cvs-mode (cvs-mode-insert . NOARGS) (file)
"Insert an entry for a specific file."
(interactive
- (list (read-file-name "File to insert: "
+ (list (read-file-name "File to insert: " nil nil nil
(ignore-errors
(cvs-fileinfo->dir
(car (cvs-mode-marked nil nil :read-only t)))))))
＠＠ -1502,7 +1510,11 ＠＠
(when parse (push `(cvs-parse-process ',dont-change-disc) postproc))
(when (member cmd '("status" "update")) ;FIXME: Yuck!!
;; absence of `cvs update' output has a specific meaning.
- (push `(dolist (fi ',fis) (cvs-fileinfo-kill ',cvs-cookies fi)) postproc))
+ (push
+ `(dolist (fi ',(or fis
+ (list (cvs-create-fileinfo 'DIRCHANGE "" "."
""))))
+ (cvs-fileinfo-kill ',cvs-cookies fi))
+ postproc))
(setq postproc (if (cdr postproc) (cons 'progn postproc) (car postproc)))
(cvs-update-header args fis)
(with-current-buffer buf