Re: Minor documentation/comment patch for 21.5
Valdis.Kletnieks(a)vt.edu writes:
This has been a whoops *forever*. Not strictly a bug (unless
somebody
decides the underlying problem is a bug). I've always preferred the
Athena-style scrollbar bindings for left/right mouse, but under XEmacs
right-mouse would always lock the keyboard up (while left-mouse was OK,
and in fact would UNlock the keyboard for me). The *underlying* problem
is that the comment in lwlib/xlwscrollbar.c says "add these translations",
but is missing one translation. There's *already* a <Btn1Up> translation
that does Release() - so left-mouse works. As listed, Bnt3Down would do
a PageUpOrLeft - but when you release the mouse button, Release() doesn't
happen, causing a keyboard wedge.
Possible bug: Should there be a <Btn3Up>: Release() in the
default_translations table in xlwscrollbar.c (there's already Release()
for Btn1Up and Btn2Up)?
Patch for the comment attached. Feel free to reject if the consensus is
that default_translations[] needs fixing instead...
If it doesn't do what is intended, it should be fixed.
Whether it should be fixed by changing comment or
default_translations[], I don't know. I'll leave the
decision to someone familiar with that code.
Could you send this patch to xemacs-patches for archival
purpose? If the patch is not there, it won't be shown up in
unreviewd patch list I'm trying to start generating again.
--
Yoshiki Hayashi