Re: [PATCH] bookmark.el of edit-utils 1.43 (completing-read usage error)
>>>> "Kyle" == Kyle Jones
<kyle_jones(a)wonderworks.com> writes:
Kyle> Uh-oh. Have we changed the parameter list of completing-read so
Kyle> that old code is now broken? If so, this is very bad.
As Hrvoje already said, the problem is not with completing-read.
bookmark.el using a parameter not avaliable in XEmacs-21.1.8's
completing-read indiscriminately in the real problem I think.
What is recommended good practice here?
Should bookmark.el not use the new argument available in
XEmacs-21.2-b26 to stay compatible with XEmacs-21.1.8?
Should bookmark.el conditionalize on the version of XEmacs it is running in?
Please advise,
Adrian
Kyle> Adrian Aichner writes:
>
> How about this little patch against bookmark.el in the edit-utils
> package?
>
> diff -u c:\XEmacs\xemacs-packages\lisp\edit-utils\bookmark.el.orig
c:\XEmacs\xemacs-packages\lisp\edit-utils\bookmark.el
> --- c:\XEmacs\xemacs-packages\lisp\edit-utils\bookmark.el.orig Mon Jan 17 14:49:58
2000
> +++ c:\XEmacs\xemacs-packages\lisp\edit-utils\bookmark.el Mon Jan 17 14:49:58 2000
> ＠＠ -503,9 +503,8 ＠＠
> bookmark-alist
> nil
> 0
> - nil
> - 'bookmark-history
> - default)))
> + default
> + 'bookmark-history)))
> (if (string-equal "" str)
> (list default)
> (list str))))
>