Re: [PATCH COMMIT] mail-lib/mail-extr.el upstream sync
>>>> "Simon" == Simon Josefsson
<jas(a)extundo.com> writes:
> This patch looks downright dubious to me. It introduces a
> large number of typos in comments,
Simon> I only found one, fixed.
I'll go back and look again then.
> purecopy'ing a defcustom value seems weird (although recent
> XEmacsen don't have an effective purecopy anyway, because of
> pdump-related changes).
Simon> I did not understand why purecopy was used, but it seemed
Simon> to work. Should it be removed?
Maybe -- there was a purecopy-removing session a while back, I don't
remember details.
I don't have time to do a thorough review, but these little
things
make me quite a bit nervous....
Simon> Most important is probably to try and run it and see if it
Simon> breaks. It works for me, and fixes reported bugs
So far so good ...
Simon> so it can't be all that bad.
*snort* Take out the "that" and you're right. ;-)
I'll try to do something about using it myself, but I just installed
Oort and things are weird ....
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
My nostalgia for Icon makes me forget about any of the bad things. I don't
have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py