Re: [PATCH] Frame crash and extra minibuffers fixes
>>>> "sb" == SL Baur <steve(a)xemacs.org>
writes:
sb>
sb> Greg Klanderman <greg(a)alphatech.com> writes:
>>>>>> "kkm" == Kirill M Katsnelson
<kkm(a)kis.ru> writes:
kkm>
kkm> This fixes [very probable cause for] crashes seen by Karl and Greg,
kkm> and solves extra minibuffers problem in ediff, reported by Greg.
sb>
> Thanks Kirill! That does it. BTW, this appears to be the
ChangeLog
> entry you were looking for:
sb>
>> 1998-03-17 SL Baur <steve(a)altair.xemacs.org>
>>
>> * frame.c (delete_frame_internal): Correct check.
sb>
> Steve, was this to fix a bug or did it just look wrong?
sb>
sb> It was to fix a bug. `called_from_delete_device' can never be less
sb> than 0 so it is a degenerate comparison.
The bug being that called_from_delete_device can never be negative, or
that this code not being run was actually causing a problem for someone?
> I see nowhere that function is called with other than 0 or 1,
> so maybe this code should just be ifdef'd out or removed?
sb>
sb> Yes, reversing the patch I made is equivalent to `if (1)' so there
sb> little point to keeping that conditional if it is causing problems.
You mean `if (0)', of course...
Can you reproduce this:
xemacs -q
<split window, load 2 files>
M-x ediff-buffers
quit ediff
M-x ediff-buffers again
Do you get spurious creation of a minibuffer only frame?
Both Kirill and I do.
greg