Re: XEmacs freezes under virtual windows on Win2K

>>>> "Ben" == Ben Wing <ben(a)xemacs.org&gt; writes:

> > >>>>> "Andy" == Andy Piper <andyp(a)bea.com&gt; writes: >

> >> >>>>> "Andy" == Andy Piper <andyp(a)bea.com&gt; writes: > >>

> >> > >> Something like this? > >> > >> Index: window.c > >> =================================================================== > >> RCS file: /pack/xemacscvs/XEmacs/xemacs/src/window.c,v > >> retrieving revision 1.52.2.1.2.3 > >> diff -u -u -r1.52.2.1.2.3 window.c > >> --- window.c 2001/12/01 05:54:21 1.52.2.1.2.3 > >> +++ window.c 2002/01/20 15:52:49 > >> ＠＠ -386,9 +386,6 ＠＠

> >> > >> -#ifdef HAVE_SCROLLBARS > >> - update_window_scrollbars (XWINDOW (win), mir, 0, 0); > >> -#endif

> >> } >

> > Perhaps I misunderstood, but: > > Once we are in mark_redisplay, GC is already in progress. It's too > late to do something pre-gc. > > Where would I put the > register_pre_gc_action (...); > call which should do the following: > > FRAME_LOOP_NO_BREAK (frmcons, devcons, concons) > { > struct frame *f = XFRAME (XCAR (frmcons)); > /* #### urk! this does tons o' crap, such as creating lots of > structs, doing window system actions, etc. we DO NOT want to > be doing this -- marking should never change any state. > i think we can just delete this. --ben */ > /* > Prompted by Ben's note above and following advice from Andy I > am trying to do this via newly implemented pre_gc_action -- > Adrian. > */ > update_frame_window_mirror, f); > } > > post_gc actions are set up like this: > > if (gc_in_progress) > /* #### way bogus! need to remove the offending call. > see mark_redisplay(). */ > register_post_gc_action (unshow_that_mofo, > (void *) SCROLLBAR_MSW_HANDLE (sb)); > > but we can't do the same for pre: > > if (gc_in_progress) > register_post_gc_action (...); > couldn't possibly work, right :-) > It would only do it previous to the next GC. > > Are you suggesting the following should also be reworked to pre_gc? > > static void > mswindows_release_scrollbar_instance (struct scrollbar_instance *sb) > { > if (gc_in_progress) > /* #### way bogus! need to remove the offending call. > see mark_redisplay(). */ > register_post_gc_action (unshow_that_mofo, > (void *) SCROLLBAR_MSW_HANDLE (sb)); > else > ShowScrollBar (SCROLLBAR_MSW_HANDLE (sb), SB_CTL, 0); > SCROLLBAR_MSW_SIZE (sb) = 0; > } > > Ready for a vacation, > > Adrian >

> >> > >> I wonder why the implementer of run_post_gc_actions has not > >> implemented run_pre_gc_actions as well. Could you think of a reason > >> why this would not be a good idea? >

> > >> What would we set up for register_pre_gc_action? > >> > >> Just a function doing > >> > >> #ifdef HAVE_SCROLLBARS > >> update_window_scrollbars (XWINDOW (win), mir, 0, 0); > >> #endif > >> > >> perhaps? >

>

>