Re: Trouble building 21.4.22
Ar an naoú lá déag de mí Feabhra, scríobh Hans de Graaff:
On Mon, 2012-02-13 at 15:20 +0900, Stephen J. Turnbull wrote:
> Alan Mackenzie writes:
>
> > This used to work fine. I think I've upgraded GCC in the meantime.
> >
> > Has anybody else seen this, or can anybody offer me any suggestions?
>
> See Julian's message for explanation. I believe there's already a
> patch in the 21.4 tree. I'll try to get it for you later.
We have fixes for this in our Gentoo patch set:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-editors/xemac...
Your patch there (xemacs-21.4.22-libpng15.patch) has a bug:
47 {
49 png_textp text;
50 int num_text;
51
53 for (i = 0 ; i < num_text ; i++)
54 {
55 /* How paranoid do I have to be about no trailing NULLs, and
56 using (int)info_ptr->text[i].text_length, and strncpy and a temp
57 string somewhere? */
58
59 warn_when_safe (Qpng, Qinfo, "%s - %s",
62 text[i].key,
63 text[i].text);
64 }
65 }
num_text is never initialised. The 21.5 change should work,
https://bitbucket.org/xemacs/xemacs/changeset/6c3a695f54f5 .
--
‘Iodine deficiency was endemic in parts of the UK until, through what has been
described as “an unplanned and accidental public health triumph”, iodine was
added to cattle feed to improve milk production in the 1930s.’
(EN Pearce, Lancet, June 2011)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta