Modifying shell-command-on-region or using call-process-region or both!?
Mats Lidell writes:
In the GNU code shell-command-on-region is called with 6
args. Actually the GNU version takes up to 7 args. (We don't have the
last two args. They are an error buffer, where output from stderr
goes, and a bool arg whether the error buffer should be displayed or
not.
XEmacs has had separation of stderr and stdout for a while. Perhaps
shell-command-on-region just needs to be updated to use that. The arg
to display the error buffer seems like it should be easy to implement.
One way of solving the issue for the go-mode is to sync our
shell-command-et-al-code with the GNU version.
I suspect that will be a mess. Better to just aim at API compatibility.
On the other hand the functionality that is implemented is a call
to the program gofmt to reformat the current buffer and replace it.
[...] This seems ideal to call from call-process-region instead of
using shell-command-on-region!?
I agree.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta