|--==> "APA" == Adrian Aichner <adrian(a)xemacs.org> writes:
>>>>>"Vin" == Vin Shelton
<acs(a)xemacs.org> writes:
Vin> I happen to agree that we don't really
care about passes, but
Vin> I ALWAYS want to know about failures. Your latest patch
Vin> doesn't produce the failure information needed:
APA> This exactly was my motivation to make the problems on all
APA> platforms visible via build-report feedback of make check*.
I'm not sure, but I think that there may have been some
misunderstanding all round here. Let me try to clarify my view which
seems to have been such a catalyst to all this.
First off, I am _NOT_ referring to what goes into a build-report at
this stage. All I'm talking about is the output from 'make check'.
Now, I'm all for verbosity, the more the merrier, I say. Verbosity is
good, verbosity gives people warm fuzzies, we should always err on the
side of verbosity. Which is why, Adrian, I initially supported your
patch to test-harness.el.
That's the good news, now the bad (not so good)...
With your patch, Adrian, after I have done a 'make check' I can't
immediately see how much of the test suite passed.
- If I'm inside XEmacs, I have to search through or scan the entire
compilation buffer. Not impossible, but a PITA, nonetheless.
- If I'm outside of XEmacs _and_ I've redirected the make output to
a file, I have to search through the output file. Still a PITA.
- If I'm outside of XEmacs, but forgot to redirect the make output
to a file, I'm screwed. I don't have a hope of finding out how
much of the test suite passed or failed.
My suggestion for a "fix" to this situation is to put a summary at the
_end_ of 'make check', in the form:
foo-tests: n of m tests successful (xxx%)
bar-tests: n of m tests successful (xxx%)
So once 'make check' completes I can see immediately how many tests
have passed. If I see anything other than "100%" I can scroll back
through the compilation buffer to find the failure(s).
Please understand that I am _NOT_ suggesting that we do away with the
verbose output from 'make check', IMO 'make check' should be as verbose
as possible. All I'm suggesting is that a summary be added to the end.
As an added enhancement, I would also like to see, after the summary,
something like:
======================================================
Total: nnnnn of mmmmm tests successful (xxx%)
Please report ANY failures via 'M-x report-xemacs-bug'
======================================================
Have I explained my views and ideas in a way that is clear and you
understand? Adrian? Steve?
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - The only _______ you'll ever need. |
| Fill in the blank, yes, it's THAT good! |
|------------------------------------<youngs(a)xemacs.org>---|