On Mon, Jan 2, 2012 at 5:26 PM, Robert Pluim <rpluim(a)gmail.com> wrote:
Also, having just tested this for other image types, the same problem
exists in at least {jpeg, png}_instantiate as well. Perhaps we should
catch that error in make-image-instance?
In fact, text-modes/image-mode.el probably should be patched like
this, since it matches the expressed intent. (did make-image-instance
change signature?)
diff --git a/image-mode.el b/image-mode.el
index e9dd55a..a6959dd 100644
--- a/image-mode.el
+++ b/image-mode.el
@@ -82,11 +82,11 @@
(let ((image (and type
(make-image-instance
(vector type :data (buffer-string start end))
- nil nil 'no-error))))
+ nil nil 't))))
(unless image
(setq image (make-image-instance
(vector 'string :data "format is not supported!\n")
- nil nil 'no-error)))
+ nil nil 't)))
(set-extent-property (make-extent start end) 'invisible t)
(let ((glyph (make-glyph image)))
(set-extent-end-glyph (make-extent end end) glyph))
It does mask a bug though, I think.
Robert
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta