Re: make-local-variable.*hook: Incorrect usage in packages and core?

Ben> Adrian Aichner wrote: Ben> what make-local-hook and add-local-hook do in addition to calling Ben> `make-local-variable' is put in a `t' somewhere in the hook, which will cause Ben> the global hooks to be run as well. otherwise, you get *only* the local hooks Ah, I read that in the docs. Ben> run, which is obviously wrong. the thing is, the routine that calls the hook Ben> has to know about this `t' business. there are different routines out there to Ben> do this, and each one has to be modified. that's what the hint means. in point Ben> of fact, there are a number of standard routines Ben> `run-hook-with-args-till-success' and so on that implement common hook Ben> semantics, so most if not all hooks already works correctly with Ben> `make-local-hook'. mouse-track hooks have their own function to run the hook Ah, so these are the "normal" hooks? So it's more like standard vs. non-standard hook implementation? Ben> [mouse-track-run-hook], which also handles the `t' correctly. [although probably Ben> we should fix this to use a standard hook.] Thanks for the details! Ben, I could not get correct behavior of mouse-track-insert between buffers, even when I make the hook local correctly in buff-menu.el. Do you also see this broken behavior? Should `Buffer-menu-maybe-mouse-select' work correctly as a local mouse-track-insert-click-hook? Ben> yes. remember that you need some special args in `add-hook' to actually get a Ben> local hook. Yep, I played with this yesterday, also tried to append (instead of prepend) the hook, to no avail. I had to add `Buffer-menu-maybe-mouse-select' to the global hook value of mouse-track-insert-click-hook to get correct mouse-track-insert behavior. Do you understand this? Ben> i made a better function add-local-hook to do this, but it's 21.4 and up only. OK, I will convert to arguments: (hook function &optional append local) semantics for compatibility with 21.1, if we come to an agreement what should be done. Best regards, Adrian Ben> -- Ben> ben Ben> I'm sometimes slow in getting around to reading my mail, so if you Ben> want to reach me faster, call 520-661-6661. Ben> See http://www.666.com/ben/chronic-pain/ for the hell I've been Ben> through. -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/