Re: GC crash on 21.2.37 (Was Re: GC crash with 21.2.36 on Solaris 2.7)
Martin Buchholz <martin(a)xemacs.org> writes:
>>>>> "GE" == Gunnar Evermann
<ge204(a)eng.cam.ac.uk> writes:
GE> I agree with the RETURN_UNGCPRO but don't think any of this is going
GE> to make a difference. handler should be GCPRO'd by call3().
No!
The old code carefully UNGCPRO'ed, and then used the unprotected
variables.
yes, but it used them to call call3_check_string which directly calls
call3, which GCPROs all argument and then calls handler.
I don't know whether the crash here was caused by unprotected
handler,
or by unprotected call3, or even if my patch actually fixes the problem.
I think the patch I just sent to xemacs-beta looks more promising :-)
We should probably apply both.
Gunnar