Re: [PATCH 21.5] fc_config object with NULL pointer

On Wed, May 14, 2014 at 12:06 PM, Jerry James <james(a)xemacs.org&gt; wrote: No, I was even more confused than was evident at first. I confused patterns and configs in my original email. It turns out that this is a known bug, and it has already been fixed in mercurial. The problem is that FcNameParse() (called in Ffc_name_parse) can return NULL. But we check for that now: if (!fcpat->fcpatPtr) /* #### Is this the best API? Could return a symbol or similar. */ invalid_argument ("unparseable Fc font name", name); So I either need to apply the existing patch to the 21.5.34 release and rebuild for Fedora, or start agitating for a 21.5.35 release. :-) Hmm, our website claims that 21.5.33 is the latest release. Side note: the name that FcNameParse() chokes on in the case of the Fedora bug is: "DejaVu Sans Mono-12:familylang=en:style=Book:stylelang=en:fullname=DejaVu Sans Mono:fullnamelang=en:slant=0:weight=80:width=100:pixelsize=16:spacing=100:foundry=unknown:antialias=True:hintstyle=2:hinting=True:verticallayout=False:autohint=False:globaladvance=True:file=/usr/share/fonts/dejavu/DejaVuSansMono.ttf:index=0:outline=True:scalable=True:dpi=96:rgba=5:scale=1:minspace=False:charset= |>^1!|>^1!P0oWQ |>^1!|>^1!|>^1!!!!%#|>^1!|>^1!|>^1!|>^1!|>^1!|>^1!|>]!ox9ao]!!!)$|>^1!|>^0s|>Ul<|>^1!|>^1!z~Ef{P)di*!!t|u!!!.%|>^1!|>^1!!BB..;wnZH|>[gE|>^0{|>XZQ|>T)%!!!1&|>^1!|>^1!|>^1!!#>r?(0~]4%tT<~|>YRc#?>K%!!!4(8?MWi|>J~~{ma}P|>^0~!!!;) !!!7)RimPQ$WUr)#F+zml8K9E!BT>Y9WNHO!!!W5#?3E%!!!Q3 {y]9#+~x?1!!$8i !!!W5 |>T)!/?6HF!!#$Dr;]W3q~F^z(1+e4%&T#Byf*＠＠{{B$~ !!#(E{}$34|>VCi|;{>WxJnq%S~^q^5^*vQ9;.pf#%k.{!!#+F9Bx6P|>^1!^{M＠P9WIli|>^1!|97t]w)J%tP+*+*!!#0G|>TE*M9v*pP0o~>|<;7s/?1rs#%lql !!#3H1Q.o1!!$eu|<lZy |>T)!|>^1!|>^1!|>^1!!!#6I|3|1＠9Ugvp|>^0~|>]1c|;$OI!!!!iz~FsO!!&cU!!#9Jx4B>+P#X02qsus$1r.a#yiR*a!!&TQ!!)n< !!#>K !!!!+ !!#AL|>^1!|>^1!|>^1!|>^1!|>^1!|>^1!|>^1!|>^1!!!#DM|>^1!{{K.!|>^1!|>^1!/?+uU!!B7) !!#GN|>]fO|>^+~Ow1gH!)pSh{}$35P0fQP!!!#4!!!0A!!#MP %rpV9!!#PQ !!&TR !!!K1 !!#SR$W1pK !!#VS yDUyF !!#]UPN0cS!!$>N !!(w|ysiAJ!!!$| !!FcS!!!1& !!+fv !!!!G !!+u{!!!!) |>6r||>^1!gm&i!!!$/f w0TUs!!+~~ |9.n]|>^1!|>^1!|>^1!ZK#{t!!.%! 3lbtU!!5[S #?>K& !!5aT |>T)!|>^1!!!!!4 !!5dU |5n[<:lang=aa|af|ar|ast|av|ay|az-az|az-ir|bm|be|bg|bi|bin|br|bs|bua|ca|ce|ch|chm|co|cs|cv|cy|da|de|el|en|eo|es|et|eu|fa|fi|fj|fo|fr|ff|fur|fy|ga|gd|gl|gn|gv|ha|haw|ho|hr|hu|hy|ia|ig|id|ie|ik|io|is|it|ka|kaa|ki|kk|kl|ku-am|kum|kv|kw|ky|la|lb|lez|ln|lt|lv|mg|mh|mi|mk|mo|mt|nb|nds|nl|nn|no|nr|nso|ny|oc|om|os|pl|pt|rm|ro|ru|sah|sco|se|sel|shs|sk|sl|sm|sma|smj|smn|so|sq|sr|ss|st|sv|sw|tk|tl|tn|to|tr|ts|tt|tw|tyv|uk|uz|ve|vo|vot|wa|wen|wo|xh|yap|yo|zu|ak|an|ber-dz|crh|csb|ee|fat|fil|hsb|ht|hz|jv|kab|kj|kr|ku-tr|kwm|lg|li|mn-mn|ms|na|ng|nv|pap-an|pap-aw|qu|quz|rn|rw|sc|sg|sn|su|ty|za:fontversion=153354:capability=otlayout\\:DFLT otlayout\\:arab otlayout\\:cyrl otlayout\\:grek otlayout\\:lao otlayout\\:latn:fontformat=TrueType:embolden=False:embeddedbitmap=True:decorative=False:lcdfilter=1:namelang=en:prgname=xemacs-xft-21.5-b34:hash=sha256\\:a82f85d87ec9a2251d93e3ca9bc34792c7c37f023dd17feadad819197a7f3a2d:postscriptname=DejaVuSansMono" Stepping through with gdb shows that fontconfig bails out and returns NULL when it hits the "charset=" part. -- Jerry James http://www.jamezone.org/ _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta