Re: [PATCH] menubar selection in mswindows
"Kirill M. Katsnelson" <kkm(a)kis.ru> writes:
I think that selection-owner-p must return the same as
(region-active-p) under Windows,
This sounds wrong. When `zmacs-regions' is nil, (region-active-p)
always returns nil, and yet the selections should still work. It is
arranged that way under X, and we should preserve that design.
and that selection-exists-p should check if CF_TEXT is available
from clipboard. Using (null (mswindows-get-clipboard)) looks too
expensive for the latter, so we must have a separate lisp primitive
for it.
I agree.
Btw, how about using lstreams to exchange clipboard data? There is
some fiddling with CR/LF stuff in select-msw.c.
Lstreams rule. Look at my latest and greatest md5.c implementation to
see how simple it is to set up a decoding lstream for that purpose.
In fact, the only thing that I *don't* like with the coding system
stuff are the CODING-SYSTEM arguments scattered all over the place.
For instance, is the CODING-SYSTEM argument to Fmd5 *really*
necessary? I wonder...
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
ED WILL NOT CORRUPT YOUR PRECIOUS BODILY FLUIDS!!