Re: [PATCH COMMIT] mail-lib/mail-extr.el upstream sync
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
>>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SJ> I think the last version (1.46) should go into the sumo, to be
SJ> on the safe side.
SY> Putting a new version in Pre-Release, and then the old version
SY> in the Sumo will be tricky, but I'll see what I can do.
SY> Just for the record, our packages repository is supposed to be
SY> a stable tree, please try to do your best to keep it that way.
This patch looks downright dubious to me. It introduces a large
number of typos in comments,
I only found one, fixed.
and a lot of really stupid capitalization in the ISO 3166 list (I
dunno, maybe those are the official names...).
Yup, I reverted that and synched the list against the current 3166
now.
purecopy'ing a defcustom value seems weird (although recent
XEmacsen
don't have an effective purecopy anyway, because of pdump-related
changes).
I did not understand why purecopy was used, but it seemed to work.
Should it be removed?
I don't have time to do a thorough review, but these little
things
make me quite a bit nervous....
Most important is probably to try and run it and see if it breaks. It
works for me, and fixes reported bugs so it can't be all that bad.