Re: [Adrian Aichner <adrian@xemacs.org>] Re: [Success] XEmacs 21.4.10 "Military Intelligence (RC2 Windows)", i586-pc-win32

Hi Stephen, with this patch (file-truename "c:\\*.txt") leads "c:\\B-r-Backtrace.txt" (the first of my many *.txt files). XEmacs 21.1.14, however does not expand the wildcard: (file-truename "c:\\*.txt") "c:\\*.txt" Adrian sjt> Mike? Andy? Anybody? What's going on here? sjt> Problems with filenames (dired and completion) on Windows are sjt> the main thing now blocking promotion of 21.4 to stable. sjt> Please, let's get this fixed. Stephen> Adrian, please try this patch to win32_readlink(): Stephen> Index: src/realpath.c Stephen> =================================================================== Stephen> RCS file: /pack/xemacscvs/XEmacs/xemacs/src/realpath.c,v Stephen> retrieving revision 1.7.2.2 Stephen> diff -u -r1.7.2.2 realpath.c Stephen> --- src/realpath.c 22 Aug 2002 10:58:34 -0000 1.7.2.2 Stephen> +++ src/realpath.c 7 Oct 2002 05:37:19 -0000 Stephen> ＠＠ -90,7 +90,7 ＠＠ Stephen> assert (*name); Stephen> /* Sort of check we have a valid filename. */ Stephen> - if (strpbrk (name, "*?|<>\"") || strlen (name) >= MAX_PATH) Stephen> + if (strpbrk (name, "|<>\"") || strlen (name) >= MAX_PATH) Stephen> { Stephen> errno = EIO; Stephen> return -1; Stephen> Note: this code has been in XEmacs since 21.2.38, so something else Stephen> has caused the recent manifestation of bugs. I'm just taking a wild Stephen> guess at what is triggering the error. I'm pretty sure this code does Stephen> get called in xrealpath() in both native and Cygwin builds, but in Stephen> different places. Stephen> I don't know if this is on the right track to resolve this problem. Stephen> Somebody is going to have to think about what "check we have a valid Stephen> filename" means, I have no idea on Windows. Stephen> -- Stephen> Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp Stephen> University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Stephen> My nostalgia for Icon makes me forget about any of the bad things. I don't Stephen> have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/