Re: package-get & md5
Hrvoje Niksic <hniksic(a)srce.hr> writes:
I understand all that, I just want to make sure that your proposed
fix
doesn't break something else.
I am not sure that this call to insert-file-contents-literally even
needs to work with EFS; Jan might know that.
I think the fix is correct. See the comment in the code there. I
wanted to use i-f-c-literally but for some reason I thought it had
gone away. The whole let form should be replaced by a single
i-f-c-literally call. (BTW where does i-f-c-literally ensure there was
no coding system conversion?)
However I still think there is a problem with file coding there. This
code presumably worked in latin-1 and Japanese environments. Given
that he also has a problem writing the file out again I think this
illustrates a general problem. IMHO, All coding systems should be such that
when an arbitrary binary file is read in with them and written back
out the things should be the same. See for instance the problems with
the KOI-8 coding system.
Jan