Re: [21.2] LDAP add and delete functions + interrupt fixes
Again, please please follow standard conventions.
The lower-level functions should be called ldap-add, ldap-delete, etc. (Or even
better, use ldap-put, ldap-remove.) No -internal, -basic-, -1, whatever. These are
parallel to the database routines.
I'm still not completely convinced we need convenience wrappers. The db interface
doesn't have them, for example.
If you want them, though, call them something like create-ldap-entry, or similar
names -- i.e. longer, to convey that they do more than you might expect. Also, the
message displaying should be optional, and not the default.
ben
Oscar Figueiredo wrote:
>>>>> "Hrvoje" == Hrvoje Niksic
<hniksic(a)iskon.hr> writes:
Hrvoje> This is good design, except that if Lisp programmers are ever
Hrvoje> expected to use the lower-level API, you should remove the
Hrvoje> "-internal" suffix and choose better names for functions.
Fine I guess I simply misjudged the meaning of "-internal" in function names.
I can rename the "-internal" functions to something else. What's your
suggestion to add the meaning "you're using stones to make fire, use the
lighter function instead otherwise if you're not really skilful you're going to
crush your fingers" to a function ? Would names like ldap-basic-add,
ldap-basic-search, ldap-basic-delete be good enough ?
Oscar
------------------------------------------------------------------------
Part 1.2 Type: application/pgp-signature
Encoding: 7bit
--
ben
--
In order to save my hands, I am cutting back on my responses, especially to
XEmacs-related mail. You
_will_ get a response, but please be patient. If you need an immediate response
and itÂ’s not apparent in
your message, please say so. Thanks for your understanding.