>>>> "Valdis" == Valdis Kletnieks
<Valdis.Kletnieks(a)vt.edu> writes:
Valdis> On 15 Feb 1999 16:13:47 EST, Paul Stodghill said:
> I think that things are even more confused than this. Consider
> the following code in make-faces-bold in faces.el,
> (when (featurep 'x)
> (frob-face-property face 'font 'x-make-font-bold locale))
> (when (featurep 'mswindows)
> (frob-face-property face 'font 'mswindows-make-font-bold locale))
> When running under CYGWIN+X, doesn't the second
"when"
> expression just clobber the results of evaluating the first?
It may very well clobber. However, the *-make-font-* functions
_should_ be checking `locale' to make sure that `locale' matches the
the particular function. The specification (abstract, as opposed to
`specifier' which is an XEmacs type) contains this information, and
the frame's "tag set" (ie, the list of properties that determines which
specification in the set given by Customize matches) should specify
whether this frame is actually a tty frame, an X frame, a MS-Windows
frame, a virtual frame (not yet imagined or implemented ;-), a stream
frame (ditto), a native Mac frame (ditto), etc. So in theory it
needn't clobber.
This functionality is rather broken in current Customize. It may be
possible to implement it with the API, but it hasn't been done yet.
> This is the behavior that I'm seeing. There are several
other
> places in faces.el where stuff like this is done...
I don't think this needs to be wrong (if the proper checks are done),
although as a coding style it is hard to understand.
Valdis> Most likely, when that code was writted, the concept of it
Valdis> even supporting mswindows correctly was quite the
Valdis> science-fiction idea, and the idea of simultaneously
Valdis> supporting an X and mswindows frame was so outrageous as
Valdis> to be discarded out of hand.
Yup. Because that code was specifically written to support FSFmacs
(at the expense of not using native XEmacs fucntionality, as usual).
Valdis> The author of the code probably thought it qualifies for
Valdis> the "11 impossible things before Lunch" needed to get into
Valdis> Milliway's. ;)
And in the context of FSFmacs as we know it today, so it is.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
__________________________________________________________________________
__________________________________________________________________________
What are those two straight lines for? "Free software rules."