Re: undefined reference in Windows

Jeff Sparkes writes: Please run autoconf yourself and commit both configure.ac and configure in such cases for the convenience of the testers. As Mike K points out, I don't think you have pushed it. Technically speaking, you're not a reviewer and you shouldn't be pushing patches until a reviewer OKs it. This one looks reasonable to me (as non-Windows user, though), fixes a serious build problem, and won't be hard to back out or repair if necessary, so you may as well push it now. If you think you're ready for it, feel free to apply for reviewer status (at xemacs-review(a)xemacs.org). FWIW, I won't veto it if others are enthusiastic, but IMO the history of a couple of your recent patches doesn't make a strong case that you have a reviewer's judgment skills combined with the knowledge of XEmacs best practices that is needed yet. If given that caveat you still think you're ready, go for it. (Also, even if we decide to wait and see *now*, your name is on my short list of candidates for the near future, and probably others' lists as well.) An alternative to being a reviewer is to publish your patches in a branch at alioth. That makes it easy for beta testers to incorporate them in their builds and test them (vs. downloading and applying patches), but of course is somewhat greater burden on you. Steve _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta