Re: [Bug: 21.5-b33] play-sound-file (and probably other sound fns) are broken
Stephen J. Turnbull writes:
Looks good to me, but I don't have a way to test it (I've
never
bothered to get the sound working on my current Linux boxen).
One question: is "wait" the right word? Ie, does XEmacs stop
responding if the sound is still playing? If so, maybe this isn't the
right way to fix it. If not, we should fix the comment.
Not sure -- as I said I did this by comparing with gnu emacs, which
also takes a _lot_ more care about buffering and such. So I suspect
that it _is_ waiting, but I don't see an alternative, given that it
does appear that closing the device before returning is the existing
behaviour. . .
Anyone who actually knows anything about alsa/pcm_sound _please_ weigh
in here with some insight!
One little nit: in
> + /* wait for it to finish -- added by HST to fix killing the thing
> + before it's actually played much if anything */
you shouldn't "sign" it unless you think there's a good reason to
suppose you know more about this than anybody else will *and* you want
to invite queries about it. Information about bugs being fixed should
be in the ChangeLog/hg log (and the email, of course!) It's usually
not needed in the code.
Ah, sorry -- that's just my habit so if I come back to this in a month
I see what's my fault. . . Feel free to edit that out!
ht
--
Henry S. Thompson, School of Informatics, University of Edinburgh
10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
Fax: (44) 131 650-4587, e-mail: ht(a)inf.ed.ac.uk
URL: http://www.ltg.ed.ac.uk/~ht/
[mail from me _always_ has a .sig like this -- mail without it is forged spam]
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta