Re: warnings in mule-canna
Didier Verna <didier(a)xemacs.org> writes:
I'm annoyed by these warnings (which probably occur also
in mule-wnn):
/usr/local/src/XEmacs-21.2/src/mule-canna.c: In function `c2mu':
/usr/local/src/XEmacs-21.2/src/mule-canna.c:1788: warning: overflow in implicit constant
conversion
/usr/local/src/XEmacs-21.2/src/mule-canna.c:1793: warning: overflow in implicit constant
conversion
/usr/local/src/XEmacs-21.2/src/mule-canna.c:1799: warning: overflow in implicit constant
conversion
/usr/local/src/XEmacs-21.2/src/gutter.c:93: warning: `frame_topmost_window' defined
but not used
They come from the fact that LEADING_BYTE_LATIN_ISO8859_1 and friends
are really consecutive char's, but defined in an enumeration.
I don't know the gutter part but at least this patch fixes
warning for mule-canna. Actually, caller of c2mu is using
unsigned char. Only c2mu uses signed char.
I also translated some doc-string. From compiler warning, I
found Fcanna_henkan_next might access endp uninitialized. I
think the patch is correct, but whenever I call
Fcanna_henkan_next it retuns nil so I cannot guess the right
behavior.
I'll commit in a few days.
2000-03-09 Yoshiki Hayashi <yoshiki(a)xemacs.org>
* mule-canna.c (Fcanna_henkan_region): Translate doc-string.
(Fcanna_henkan_next): Ditto.
(Fcanna_bunsetu_henkou): Ditto.
(Fcanna_henkan_kakutei): Ditto.
(Fcanna_henkan_end): Ditto.
(Fcanna_henkan_quit): Ditto.
(Fcanna_henkan_next): Set retun value correctly.
(c2mu): Use unsigned char instead of signed char.
--
Yoshiki Hayashi
Attachments:
- mule-canna.c.diff (application/octet-stream — 1.7 KB)