[issue488] Re: VC submenu under Tools

Ville Skyttä wrote: > Looks like the XEmacs specific menu code is quite outdated and plain broken in > some cases indeed - it comes from the ages when only CVS, RCS and SCCS were > supported. It's also quite painful to maintain and keep in sync the first > menu label with what actually happens with vc-next-action with various > backends (vc-next-action is what gets called anyway, no matter what the label > is), so I'm inclined to apply the attached patch which is kind of the same > approach as you suggested above, but applied to all backends and simplifies > things quite a bit. Comments? > Sounds good. I didn't want to say it, but the code did look too complicated to begin with :o) >> I think this says that (process-mark p) does not return a valid marker. >> The definition of vc-exec-after is on line 943 of vc.el >> and (process-mark p) is on line 962 inside that function. >> Oh... and by the way, commenting out that line fixes the bug!!! > Hm, I can't reproduce with XEmacs 21.5.28. Which version of XEmacs do you > have? Replacing the line with > > (ignore-errors (goto-char (process-mark p))) > > rather than commenting it out could be somewhat better, but that probably > isn't a very good thing to do either - I suppose there's a real issue > somewhere needing a proper fix. Could you try the above out anyway? And of > course, help from anyone with finding/fixing the real problem is much > appreciated. > Although I contribute to the xemacs-beta mailing list, I almost always use the latest stable release. In all the "excitement", I lost my head! Anyways, that works. And now I'm getting these lines which I don't remember seeing before. Could it be these are the real culprits (the last 2 especially)? While compiling vc-buffer-context: ** variable mark-active bound but not referenced While compiling vc-next-action-on-file: ** reference to free variable find-file-literally While compiling vc-next-action-dired: ** evaluating (< nil 0): (wrong-type-argument number-char-or-marker-p nil) ** evaluating (= nil 0): (wrong-type-argument number-char-or-marker-p nil)