Re: [PATCH] Toolbar fixes

kkm> I started fixing one bug, and found whole bughillock... All these are kkm> reproduced in 20.3 A big THANK YOU for looking at the toolbar implementation. There have been lots of bugs here for a long time. Also please try the following test to make sure you've got it right: (defmacro toggle-boolean-specifier (s prefix-arg &optional domain) (if (fboundp 'boolean-specifier-p) `(and (boundp (quote ,s)) (boolean-specifier-p ,s) (set-specifier ,s (cons (if ,domain ,domain 'global) (cond ((= ,prefix-arg 1) ; toggle (not (specifier-instance ,s))) ((> ,prefix-arg 1) t) (t nil))))) nil)) (defun toggle-toolbar (arg &optional domain) (interactive "p") (cond ((boundp 'default-toolbar-visible-p) (toggle-boolean-specifier default-toolbar-visible-p arg domain)))) Now do: M-x split-window ;; necessary to trigger redisplay problems for me M-x toggle-toolbar ;; make sure the toolbar actually toggles M-x toggle-toolbar Martin