Re: EFS 1.19 bug: Cannot "List and Install" packages
>>>> "Ben" == Ben Wing <ben(a)666.com>
writes:
Ben> i've never seen problems from the attempt to cwd to a file.
Ben> this probably has nothing to do with things, but i had
Ben> problems awhile ago with efs until applying the attached.
Hello Ben,
have you sent this patch to the maintainer of EFS
Author version: 1.19 2000-03-27: Mike Sperber
<sperber(a)informatik.uni-tuebingen.de>
also?
What is the status of this patch?
Best regards,
Adrian
Ben> Dmitry Yaitskov wrote:
> I applied this patch, and it helped - kind of... but getting the
> package index still fails, with the following messages:
>
> ----------------------------- cut here -----------------------------
> Opening FTP connection to ftp.xemacs.org...
> Logging in as user anonymous...
> Logging in as user anonymous...done
> CWD'ing to /anonymous＠ftp.xemacs.org:/pub/xemacs/packages/...
> CWD'ing to /anonymous＠ftp.xemacs.org:/pub/xemacs/packages/...done
> Listing /anonymous＠ftp.xemacs.org:/pub/xemacs/packages/...
> Listing /anonymous＠ftp.xemacs.org:/pub/xemacs/packages/...done
> Opening input file: No such file or directory,
/anonymous＠ftp.xemacs.org:/pub/xemacs/packages/package-index.LATEST.pgp
> ----------------------------- cut here -----------------------------
>
> (And this also happens with --vanilla.) I'm stumped... any ideas? One
> thing that's changed is, I moved from nt4 to w2k - but how could this
> be related I don't know.
>
> Adrian Aichner <aichner(a)ecf.teradyne.com> wrote:
>
> > To whom it may concern:
> <snip>
> >
> > xemacs-packages/libs/efs/ChangeLog:
> >
> > 2000-07-11 Adrian Aichner <aichner(a)ecf.teradyne.com>
> >
> > * efs.el (efs-get-file-entry): Perform `efs-get-files' for dir,
> > not path, which could be a file.
> >
> > xemacs-packages patch:
> >
> > cd d:\tmp\xemacs-packages\
> > cvs diff libs/efs
> > Compilation started at Tue Jul 11 12:15:49 2000 +0200 (W. Europe Daylight Time)
> > ? libs/efs/bindist.err
> > ? libs/efs/distclean.err
> > ? libs/efs/make.exe.stackdump
> > cvs server: Diffing libs/efs
> > Index: libs/efs/efs.el
> > ===================================================================
> > RCS file: /usr/CVSroot/XEmacs/xemacs-packages/libs/efs/efs.el,v
> > retrieving revision 1.9
> > diff -u -r1.9 efs.el
> > --- efs.el 2000/05/19 16:00:54 1.9
> > +++ efs.el 2000/07/11 10:17:48
> > ＠＠ -6351,7 +6351,7 ＠＠
> > (or (and efs-allow-child-lookup
> > (efs-allow-child-lookup host-type
> > host user r-dir file)
> > - (setq ent (efs-get-files path t))
> > + (setq ent (efs-get-files dir t))
> > (efs-get-hash-entry "." ent))
> > ;; i.e. it's a directory by child lookup
> > (efs-get-hash-entry
> <snip>
>
> --
> Cheers,
> -Dima.
Ben> --
Ben> Ben
Ben> In order to save my hands, I am cutting back on my mail. I also write
Ben> as succinctly as possible -- please don't be offended. If you send me
Ben> mail, you _will_ get a response, but please be patient, especially for
Ben> XEmacs-related mail. If you need an immediate response and it is not
Ben> apparent in your message, please say so. Thanks for your understanding.
Ben> See also http://www.666.com/ben/chronic-pain/
Ben> Index: efs.el
Ben> ===================================================================
Ben> RCS file: /usr/CVSroot/XEmacs/xemacs-packages/libs/efs/efs.el,v
Ben> retrieving revision 1.9
Ben> diff -u -r1.9 efs.el
Ben> --- efs.el 2000/05/19 16:00:54 1.9
Ben> +++ efs.el 2000/07/12 09:12:35
Ben> ＠＠ -354,6 +354,12 ＠＠
Ben> ;; List of gateway types for which we need to do explicit file handling on
Ben> ;; the gateway machine.
Ben> +(defconst efs-null-device (cond ((boundp 'null-device) null-device)
Ben> + ((boundp 'grep-null-device) grep-null-device)
Ben> + ((eq system-type 'windows-nt) "nul")
Ben> + (t "/dev/null"))
Ben> + "Filename corresponding to the null device.")
Ben> +
Ben> ;;;; ------------------------------------------------------------------
Ben> ;;;; User customization variables. Please read through these carefully.
Ben> ;;;; ------------------------------------------------------------------
Ben> ＠＠ -588,7 +594,15 ＠＠
Ben> ;;; End of gateway config variables.
Ben> (defcustom efs-tmp-name-template
Ben> - (concat (if (fboundp 'temp-directory) (temp-directory)
"/tmp") "/efs")
Ben> + (concat (if (fboundp 'temp-directory)
Ben> + ;; we may be calling the cygwin ftp client, regardless of
Ben> + ;; whether we're running a cygwin version of xemacs, and it
Ben> + ;; doesn't accept \'s in filenames. the windows ftp client
Ben> + ;; accepts /'s, so use them.
Ben> + (if (eq system-type 'windows-nt)
Ben> + (replace-in-string (temp-directory) "\\\\" "/")
Ben> + (temp-directory))
Ben> + "/tmp") "/efs")
Ben> "Template used to create temporary files.
Ben> If you are worried about security, make this a directory in some
Ben> bomb-proof cave somewhere. efs does clean up its temp files, but
Ben> ＠＠ -6490,7 +6504,7 ＠＠
Ben> (memq host-type efs-unix-host-types)
Ben> (let ((line (nth 1 (efs-send-cmd
Ben> host user
Ben> - (list 'get tilde "/dev/null")
Ben> + (list 'get tilde efs-null-device)
Ben> (format "expanding %s" tilde)))))
Ben> (setq res
Ben> (and (string-match efs-expand-dir-msgs line)
Ben> ＠＠ -10175,7 +10189,8 ＠＠
Ben> ;; Try to get tilde.
Ben> ((null dir)
Ben> (let ((tilde (nth 1 (efs-send-cmd
Ben> - host user (list 'get "~" "/dev/null")))))
Ben> + host user (list 'get "~"
Ben> + efs-null-device)))))
Ben> (cond
Ben> ;; super dumb unix
Ben> ((string-match efs-super-dumb-unix-tilde-regexp tilde)