Re: Fix for pdump under mswin, was Re: [Failure] XEmacs 21.2-b31 "Iris", i586-pc-win32, USE_PORTABLE_DUMPER=1

On Wed, Mar 15, 2000 at 03:19:55AM -0700, Ben Wing wrote: > Oh puhleeeze Olivier, don't give me that anti-MS shit. That wasn't anti-MS. That was anti-cast. I had to track down too many breakages due to unnecessary casts (especially on 64bits architectures) to accept adding junk ones to silence buggy warnings. Even gcc warnings, mind you. I'd rather spend time fixing gcc. The only ones I accept (with clenched teeth however) are the casts-from-void* necessary to make the C++ compilers happy, and that's because they otherwise spew out errors. > That cast in memcpy cannot possibly introduce a bug. What do you think I meant by that: > > For instance, the day the lrecord_implementations_table becomes a > > const table. We may decide someday to change the table into a constant one (after all it is a table of pointers to constant structures with constant indexes). If someone forgets about the memcpy, it may or may not segfault, depending of the phase of the moon. OG.