Re: Tweaks for find-func.el

Thanks for the patch, Steve. [I am afraid I have been too busy recently with work and looking for a new job to have any time to give to XEmacs. :-( ] The patch looks pretty harmless: sb> The following patch eliminates an unused local variable, and sb> makes the return value of find-function-do-it meaningful. sb> 1998-05-10 SL Baur <steve(a)altair.xemacs.org&gt; sb> * find-func.el (find-function-do-it): Make return value sb> meaningful. (find-function-noselect): Eliminate sb> unused local variable. From Bob Weiner sb> <weiner(a)altrasoft.com&gt; sb> --- xemacs-devel/find-func.el~ Mon Apr 6 13:44:44 1998 sb> +++ xemacs-devel/find-func.el Sun May 10 17:16:17 1998 sb> ＠＠ -176,7 +176,7 ＠＠ sb> (and (subrp (symbol-function function)) sb> (error "%s is a primitive function" function)) sb> (let ((def (symbol-function function)) sb> - library aliases) sb> + aliases) Well spotted, thanks. (I think it was previously needed and I must have forgotten to take it away...) sb> ＠＠ -243,7 +243,8 ＠＠ sb> (when (memq (car buffer-point) orig-buffers) sb> (push-mark orig-point)) sb> (goto-char (cdr buffer-point)) sb> - (recenter 0)))) sb> + (recenter 0) sb> + t))) This is ok, but why is it so desirably to have a return value of t rather than nil. As far as I am concerned this function doesn't return any meaningful value anyway: it raises an error if it fails to find what it is looking for. Cheers, Jens -- Jens-Ulrik Holger Petersen <http://www.kurims.kyoto-u.ac.jp/~petersen/> Research Institute for Mathematical Sciences, Kyoto University