Thanks for trying this! A few comments:
Mats Lidell writes:
- memcmp (ptr, (Rawbyte *) ptr + 1, len - 1);
+ // memcmp (ptr, (Rawbyte *) ptr + 1, len - 1);
Please use classic C comments. We should still build on compilers
that don't allow C++ comments in C.
+ memcmp (ptr, ((char*)ptr + 1), len - 1);
This is bad; AFAIK Rawbyte is a typedef for char. That may not be
true for C++, in which case this might need to be conditionally
compiled for C++.
Index: src/font-mgr.h
===================================================================
- eicpy_ext(eistrpxft_name, name, Qfc_font_name_encoding); \
+ eicpy_ext(eistrpxft_name, (Extbyte*)name, Qfc_font_name_encoding); \
I'm sure I fixed this correctly, ...
Index: src/linuxplay.c
===================================================================
- int wrtn,rrtn,crtn,prtn;
+ int wrtn,crtn;
+ size_t rrtn,prtn;
and this, too. Are you sure your sources are up-to-date?
/* We need to read at least the header information before we can
start
Index: src/objects-tty.c
===================================================================
- font, 0, -1, 0))
+ font, 0, -1, initial))
and something that looked an awful lot like this.
Index: src/sysdep.h
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/sysdep.h,v
retrieving revision 1.22
diff -u -r1.22 sysdep.h
--- src/sysdep.h 2004/02/25 20:05:33 1.22
+++ src/sysdep.h 2007/05/30 07:03:26
@@ -26,10 +26,6 @@
#include <setjmp.h>
-#ifndef WIN32_NATIVE
-extern char **environ;
-#endif
-
#ifdef PDUMP
int pdump_read_file (char **pdump_start_pos, size_t *pdump_length);
#endif
@@ -67,6 +63,10 @@
void unrequest_sigio (void);
BEGIN_C_DECLS
+
+#ifndef WIN32_NATIVE
+extern char **environ;
+#endif
void stop_interrupts (void);
void start_interrupts (void);
This is the one that Ivan caught.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta