Re: [PATCH COMMIT] mail-lib/mail-extr.el upstream sync
Steve Youngs <youngs(a)xemacs.org> writes:
|--==> "SJ" == Simon Josefsson <jas(a)extundo.com>
writes:
SJ> "Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
>>purecopy'ing a defcustom value seems weird (although recent XEmacsen
>>don't have an effective purecopy anyway, because of pdump-related
>>changes).
SJ> I did not understand why purecopy was used, but it seemed to work.
SJ> Should it be removed?
The way I understand it, purecopy was only to be used for things that
get dumped with xemacs.
This is how it used to work, AFAIU. The same applies to Emacs. With
the new dumper, purecopy in XEmacs is a no-op.
| This function is a no-op except while XEmacs is being built
and
| dumped; it is usually called only in the file
| `xemacs/lisp/prim/loaddefs.el', but a few packages call it just in
| case you decide to preload them.
`----
Looking at that, I'd say yes you should remove _all_ the 'purecopy's
from mail-extr.el, but _especially_ from the defcustoms.
Like Hrvoje said, it is currently only there for backwards
compatibility and it is documented to be a no-op. Keeping it as is
eases maintainance, but I'll suggest it to Emacs and incorporate it
into mail-lib if changed. Unless someone disagrees.