>>>> "Simon" == Simon Josefsson
<jas(a)extundo.com> writes:
Simon> Optional seventh argument CODING-SYSTEM
We should make all of these CODING-SYSTEM arguments go away. They
normally get implemented internally to the function by dynamically
binding a variable. That's pretty evil, too, but as long as that is
true (let ((coding-system-for-write codesys)) (write-region ...)) is a
workaround.
Simon> Grep:ing through the XEmacs core I can't find anywhere
Simon> where the CODING-SYSTEM parameter is used. Neither in
Simon> XEmacs mule packages.
Simon> Grep:ing through the XEmacs packages I can find at least
Simon> one place where it is used
Simon> INCORRECTLY. (`ediff-make-empty-tmp-file')
Simon> CODING-SYSTEM is used in jka-compr.el, mule-sysdp.el and
Simon> nnmail.el, but seems to be there just because they provide
Simon> wrappers for write-region.
OK, thanks for checking. Nothing in APEL? That's strange.
Simon> How about ditching the CODING-SYSTEM parameter in favor of
Simon> the MUSTBENEW?
I don't have a problem with this in the long run, given your analysis.
Simon> (Of course, `write-region' could look at the argument to
Simon> see if it is a coding system or not and support both XEmacs
Simon> and Emacs syntax. But it's not nice.)
But as long as we can't prove that somebody somewhere is not using
that argument ....
This is what I would want for 21.4. It's probably the way we should
start in 21.5. You can do a display-warning that the CODESYS usage is
obsolete.
Also, I detest the use of "anything else means ..." in these contexts.
Please document a specific value such as 'ask (or t, I'll bet that's
what the FSF uses when they use it :-( ) for the confirmation. Of
course for compatibility we accept other values (maybe display-warning
about them). We should coordinate with the FSF on this if possible
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."