Re: [gshapiro@sendmail.org: Fix for supercite and the "emailname" attribute]

gshapiro> I just wanted to make sure this bug fix didn't get lost in the gshapiro> shuffle. I apologize for the duplicate but I never heard back gshapiro> after sending it in last time. gshapiro> The problem is that sc-attribs-emailname calls gshapiro> sc-attribs-%＠-addresses which simply matches the first string gshapiro> which contains legal e-mail address characters. It uses the full gshapiro> sender string, e.g. "Gregory Neil Shapiro gshapiro> <gshapiro(a)sendmail.org&gt;&quot;. In that case, the first string is gshapiro> "Gregory". This makes the "emailname" attribute useless as it is gshapiro> the same as "firstname". After comparing the original supercite with the xemacs version, I think I found the real problem. The "delim" parameter is being ignored by sc-attribs-%＠-addresses. A new patch: --- supercite.el~orig Sat Mar 27 18:06:20 1999 +++ supercite.el Sat Aug 28 01:48:28 1999 ＠＠ -1009,7 +1009,7 ＠＠ called with DELIM \"＠\". If DELIM is nil or not provided, matches addresses of the style ``name''." ;; Handle X.400 addresses where G & S fields contain the sender name. - (if (string-match "/[GS]=\\([-a-zA-Z0-9_.]+\\)\\|\\([-+a-zA-Z0-9_.]+\\)" from) + (if (string-match (concat "/[GS]=\\([-a-zA-Z0-9_.]+\\)\\|\\([-+a-zA-Z0-9_.]+\\)" delim) from) (if (match-beginning 2) (substring from (match-beginning 2) (match-end 2)) (substring from (match-beginning 1) (match-end 1)))))