APPROVE COMMIT NOTE: This patch has been committed # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net&gt; # Date 1524640442 -3600 # Wed Apr 25 08:14:02 2018 +0100 # Node ID 262dc5a418f5aed7f0284e8d63e39ba6a529166c # Parent c5889f9bb7f42149ee575ea6553eebe24a2652b8 Handle non-numeric STATUS more gracefully, make-docfile.el lisp/ChangeLog addition: 2018-04-25 Aidan Kehoe <kehoea(a)parhasard.net&gt; * make-docfile.el (docfile-out-of-date): #'call-process can return a non-integer if the underlying process signaled, and exited for that reason. Handle this more gracefully. diff -r c5889f9bb7f4 -r 262dc5a418f5 lisp/ChangeLog --- a/lisp/ChangeLog Mon Apr 23 13:43:40 2018 +0100 +++ b/lisp/ChangeLog Wed Apr 25 08:14:02 2018 +0100 ＠＠ -1,3 +1,9 ＠＠ +2018-04-25 Aidan Kehoe <kehoea(a)parhasard.net&gt; + + * make-docfile.el (docfile-out-of-date): + #'call-process can return a non-integer if the underlying process + signaled, and exited for that reason. Handle this more gracefully. + 2018-04-10 Aidan Kehoe <kehoea(a)parhasard.net&gt; * code-files.el (write-region): diff -r c5889f9bb7f4 -r 262dc5a418f5 lisp/make-docfile.el --- a/lisp/make-docfile.el Mon Apr 23 13:43:40 2018 +0100 +++ b/lisp/make-docfile.el Wed Apr 25 08:14:02 2018 +0100 ＠＠ -245,16 +245,17 ＠＠ ;; (expand-file-name "make-docfile" build-lib-src) "make-docfile" nil + ;; Wouldn't it be nice to have streams as process input and + ;; output. (list t standard-error) nil - (append options processed)))) - (if (equal status 0) - (message "%sSpawning make-docfile ...done" - (buffer-substring nil nil standard-error)) - (message "%sSpawning make-docfile ... error, failed with status %d." - (buffer-substring nil nil standard-error) - status)) - (kill-emacs status))) + (append options processed))) + (numeric-status (if (integerp status) status 1))) + (write-sequence (buffer-substring nil nil standard-error) + 'external-debugging-output) + (message "Spawning make-docfile ... %s" + (if (zerop numeric-status) "done" status)) + (kill-emacs numeric-status))) (kill-emacs) -- ‘As I sat looking up at the Guinness ad, I could never figure out / How your man stayed up on the surfboard after forty pints of stout’ (C. Moore)